Repository navigation

Sort props in noir contract artifact when loading #6021

Closed

Labels

A-securityteam-fairies

opened

on Apr 25, 2024

Right now we can import and compute the hash of a contract artifact with unsorted output functions. We need to make sure these are deterministic before hashing it otherwise we end up with an artifact with different hashes but the same input.

Search TODO: #6021
Related to #5875.

github-project-automation
added this to A3on Apr 25, 2024
github-project-automation
moved this to Todo in A3on Apr 25, 2024
sklppy88
linked a pull request that will close this issuefix: sorting artifact props and members in metadata #9772 on Nov 11, 2024
sklppy88
added
team-fairiesNico's team

A-securityArea: Relates to security. Something is insecure.
on Nov 14, 2024
sklppy88
added a commit that references this issue on Nov 19, 2024
fix: add zod parsing for generated contract artifacts (#9905)
e1ef998
sklppy88
closed this as completedin #9772 on Nov 20, 2024
github-project-automation
moved this from Todo to Done in A3on Nov 20, 2024

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

A-securityteam-fairies

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests