Skip to content

bug: Partial notes are emitted as bytes, but encoded as Fields #9835

Closed
Closed
bug: Partial notes are emitted as bytes, but encoded as Fields#9835
Labels
C-aztec.nrComponent: Aztec smart contract frameworkT-bugType: Bug. Something is broken.team-fairiesNico's team

Description

@Thunkar
Thunkar
opened on Nov 8, 2024

The partial note finalization log is emitted (in macro-generated code, maros/notes/mod.nr/generate_finalization_payload) as an array of Fields, but each one of them is populated by a single byte. This causes decoding issues when trying to read the tag, plus of course consumption of outrageous amounts of DA.

Activity

  1. Thunkar
    added
    C-aztec.nrComponent: Aztec smart contract framework
    T-bugType: Bug. Something is broken.
    team-fairiesNico's team
    on Nov 8, 2024
  2. nventuro
    added this to the TestNet milestone on Nov 8, 2024

  3. nventuro commented on Nov 12, 2024

    @nventuro
    nventuro
    on Nov 12, 2024
    Contributor

    There's a test we need to re-enable in archiver_store_test_suite.ts once we fix this.

  4. MirandaWood
    added a commit that references this issue on Jan 20, 2025

    feat!: public logs (#11091)

    f4725d2
  5. nventuro
    removed this from the TestNet milestone on Jun 2, 2025

  6. nventuro commented on Jun 3, 2025

    @nventuro
    nventuro
    on Jun 3, 2025
    Contributor

    This has been long fixed.

  7. nventuro
    closed this as completedon Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-aztec.nrComponent: Aztec smart contract frameworkT-bugType: Bug. Something is broken.team-fairiesNico's team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions