Skip to content

fix: also publish to version tag if on master, not just to master #10196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Maddiaa0 wants to merge 1 commit into from
Closed

fix: also publish to version tag if on master, not just to master #10196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/publish-aztec-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ jobs:
with:
concurrency_key: publish-npm
dockerhub_password: "${{ env.DOCKERHUB_PASSWORD }}"

- name: Publish bb.js NPM package
run: |
DEPLOY_TAG=${{ env.DEPLOY_TAG }}
Expand Down Expand Up @@ -335,11 +335,15 @@ jobs:
working-directory: ./aztec-up/terraform
run: |
terraform init

# Also publish a master tag if we're on the master branch
if [ "${{ github.ref_name }}" == "master" ]; then
TAG=master
else
TAG=${{ env.DEPLOY_TAG }}
export TF_VAR_VERSION=${TAG#aztec-packages-v}

@spypsy spypsy Nov 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR here which I forgot to merge 🤦 : #10095
This fixes the issue you're tackling here

@spypsy spypsy Nov 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged now

terraform apply -auto-approve
fi

TAG=${{ env.DEPLOY_TAG }}
export TF_VAR_VERSION=${TAG#aztec-packages-v}
terraform apply -auto-approve

Expand Down