chore: noir subrepo experiment (WIP, do not merge) - #1082
Closed
ludamad wants to merge 2 commits into
Closed
Conversation
Collaborator
Author
|
Clearing currently inactive PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What if we used a git subrepo bundled copy of noir-lang/noir?
This would allow prototyping changes from within aztec entirely if we need to do full stack changes, and then making a noir PR as needed with
git subrepo push noir <branch>. We can periodicallygit subrepo pull noir <branch>as well.This does NOT copy Noir history, and this tool condenses history every pull. Noir repo is the source of history.
This does NOT monorepo Noir, although the source is bundled. The intent is that PR's can get reviewed by Noir folks in aztec-packages, but they should always still make their way as separate Noir PR's.
Alternatives: git subtree (most similar, keeps history however), git submodules (I feel like sentiment is: stay away), monorepoing Noir (personally in favour, but probably the most reasonable split if there is one as well + obviously not Noir's ideal end state)
Checklist: