chore: fixing `@safety` warnings by benesjan · Pull Request #11094 · AztecProtocol/aztec-packages

benesjan · 2025-01-07T19:59:28Z

Note for reviewer

I originally addressed a bunch of other stuff in this PR but as @nventuro pointed out it became too messy so I separated those changes into a PR up the stack.

Merging currently blocked by this nargo fmt bug

benesjan · 2025-01-07T19:59:54Z

refactor: random fixes and readability improvements #11129
chore: fixing @safety warnings #11094 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

nventuro · 2025-01-07T20:23:40Z

@fcarreiro this is an old issue from october that doesn't seem to have much activity or tracking - is there any blocker to getting this done?

Maybe it's a good idea to add tracking, you are right. The pointed ticket is tracking something else which is considered done.

Regarding a solution: TBH IDK how to solve it, and currently the AVM team is quite busy with other stuff. IDK if we'd be able to come back to this until just after Ignition (especially since it's not really an AVM thing).

Possible solutions: (1) The easy way to make this secure, IIRC, is to constrain the hashes there in place. Something like assert(old_hash == hash([a,b,c])) and assert(new_hash == hash([selector,a,b,c]). This would blow up the constraints and when I was doing this everyone was chipping away constraints so I thought it wouldn't fly.
(2) Something that I tried was to change the the private interfaces (macros) and call methods to take a slice. Then I could do the same as I did in public. This didn't work because sizes need to be known at comptime sadly.
(3) The other possible solution (more elegant from some PoV and less from other) is to change all the users of the "call with hash" method to include the selector themselves. IIRC from a discussion with Palla, the major offenders and only real need for passing the hash are the contract (?) entry points which then kind of call other functions with an already given set of params. Selectors are now an aztec-nr/js only concept but IIRC then it would be ok to change the JS code to insert the selector appropiately.

This is all from the top of my mind so there might be mistakes. Please add that info if you create a ticket, thanks!

nventuro · 2025-01-07T20:34:22Z

I don't think the Noir team would necessarily be happy about exposing this in their stdlib - did you check with them?

No, decided to go ahead and then tag Tom for a review as the change is easy to revert.

I would prefer to keep this as an internal implementation detail to the stdlib. If you need something similar then you can vendor it into aztec-nr.

That would require me to copy not only from_field_unsafe but also compute_decomposition which seems like quite a lot of code to copy and I feel like it does not really belong to Aztec.nr (it feels too low-level).

But maybe we could make the API std nicer by moving the from_field_unsafe func to EmbeddedCurveScalar just like was done for from_field?

compute_decomposition is a very small function though?

Regardless, the noir stdlib is a very conservative library as breaking changes are a breaking change to the language itself. We're not going to be exposing this function oublically for that reason.

@TomAFrench As you please. I will revert this change as the scope of the PR is already quite big and don't want to make it bigger.

Regardless, the noir stdlib is a very conservative library as breaking changes are a breaking change to the language itself.

I feel like in this case this might not be that big of a deal because we are exposing the function and if we did the change I proposed we would be moving a function which was not intended for external use. So the breaking change would be only for users that used the func anyway just like we did in aztec-packages.

I would also argue that us needing this function is a good sign that it's desirable to expose.

But the best approach might be to just change the API such that we don't need the function. Which could be done by having an MSM func that takes in the values from the smaller field and then does the conversion on its own. This would also improve safety since we rely on MSM to constrain the limbs.

@TomAFrench WDYT?

TomAFrench · 2025-01-08T11:14:39Z

Merging master as I want to check if failures in another branch are from master.

TomAFrench · 2025-01-09T15:58:43Z

Note that the format of safety comments is in the process of changing.

benesjan · 2025-01-10T18:13:05Z

@TomAFrench @nventuro could I get an approval here or are we waiting for new Noir sync?

I've already addressed all of Nico's comments here and it now contains only safety warnings so I think this should be fine to merge.

I am having too many PRs open...

TomAFrench · 2025-01-10T22:23:04Z

As soon as ci is unfucked we're going to be merging a change to the safety comment format so i think we should either hold off until that's in or just preemptively switch to the new format .

TomAFrench · 2025-01-13T09:15:53Z

The new comment format is now in Aztec packages

Sets the L1 tx utils timeout to the end of the L2 slot.

@safety

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.71.0</summary> ## [0.71.0](aztec-package-v0.70.0...aztec-package-v0.71.0) (2025-01-17) ### Features * Track block building helpers ([#11190](#11190)) ([a749dc1](a749dc1)), closes [#11184](#11184) </details> <details><summary>barretenberg.js: 0.71.0</summary> ## [0.71.0](barretenberg.js-v0.70.0...barretenberg.js-v0.71.0) (2025-01-17) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.71.0</summary> ## [0.71.0](aztec-packages-v0.70.0...aztec-packages-v0.71.0) (2025-01-17) ### ⚠ BREAKING CHANGES * `loop` statements (only frontend) (noir-lang/noir#7092) * Include kind in `StructDefinition::generics` and fix derivation of Eq in structs with numeric generics (noir-lang/noir#7076) * Attestation collection times out based on sequencer timetable ([#11248](#11248)) ### Features * `loop` statements (only frontend) (noir-lang/noir#7092) ([a964cd0](a964cd0)) * Add `ConstrainNotEqual` instruction (noir-lang/noir#7032) ([a964cd0](a964cd0)) * Archive public testnet tx data ([#11192](#11192)) ([66f2014](66f2014)) * Backup proof failures to google cloud storage ([#11255](#11255)) ([b4775fd](b4775fd)), closes [#11062](#11062) * **docs:** Algolia->typesense ([#11034](#11034)) ([d254f49](d254f49)) * Improve PXE contract DB capabilities ([#11303](#11303)) ([fab5570](fab5570)) * **LSP:** Auto-import trait reexport if trait is not visible (noir-lang/noir#7079) ([a964cd0](a964cd0)) * Process note logs in aztec-nr ([#10651](#10651)) ([708139d](708139d)) * Reenable constrained config for roots ([#10605](#10605)) ([a6ebc2e](a6ebc2e)) * **spartan:** Add extra accounts ([#11300](#11300)) ([7782836](7782836)) * **ssa:** Treat globals as constant in a function's DFG (noir-lang/noir#7040) ([a964cd0](a964cd0)) * Track block building helpers ([#11190](#11190)) ([a749dc1](a749dc1)), closes [#11184](#11184) ### Bug Fixes * Allow implicit associated types on integer type kinds (noir-lang/noir#7078) ([a964cd0](a964cd0)) * Do not remove memory blocks used as brillig input (noir-lang/noir#7073) ([a964cd0](a964cd0)) * Ensure 'docker info' works before preceding ([#11286](#11286)) ([0b0e81a](0b0e81a)) * Fail in proxy deployment should fail the step ([#11308](#11308)) ([b780d75](b780d75)) * Faster polling times for archiver and sequencer ([#11262](#11262)) ([d70511e](d70511e)) * Https://github.com/AztecProtocol/aztec-packages/issues/8939 ([66f2014](66f2014)) * Idempotent deploy-l1-contracts with initial validators ([#11284](#11284)) ([3a3f9c0](3a3f9c0)), closes [#11283](#11283) * Include kind in `StructDefinition::generics` and fix derivation of Eq in structs with numeric generics (noir-lang/noir#7076) ([a964cd0](a964cd0)) * Legacy runner start ([#11291](#11291)) ([0b2a619](0b2a619)) * Reallocate commitment key to avoid pippenger error ([#11249](#11249)) ([8fc2011](8fc2011)) * References to a3 in docs ([#11256](#11256)) ([caf88fa](caf88fa)) * Remove bb path override in cli-wallet ([#11280](#11280)) ([a6a226e](a6a226e)) * Resolve misc bugs handling phases in avm witgen ([#11218](#11218)) ([29bc4bd](29bc4bd)) * Sequencer timetable accounts for spare time ([#11221](#11221)) ([f1b9211](f1b9211)) * Validator ignores block limits during reexec ([#11288](#11288)) ([920a521](920a521)) ### Miscellaneous * Add circuit input checks to bootstrap.sh ([#11261](#11261)) ([a718b15](a718b15)) * Add regression test for [#6530](#6530) (noir-lang/noir#7089) ([a964cd0](a964cd0)) * Add test for isuee [#7090](#7090) (noir-lang/noir#7091) ([a964cd0](a964cd0)) * Allow passing custom conditions to inlining pass (noir-lang/noir#7083) ([a964cd0](a964cd0)) * Attestation collection times out based on sequencer timetable ([#11248](#11248)) ([946a418](946a418)) * **avm:** Calldata, returndata slices out of range padded with zeros ([#11265](#11265)) ([a469c94](a469c94)), closes [#10933](#10933) * Delete external-ci-approved.yml ([#11258](#11258)) ([642bce6](642bce6)) * Demote error closing forks to warn ([#11263](#11263)) ([a5b7a6a](a5b7a6a)) * Do not make new instruction if it hasn't changed (noir-lang/noir#7069) ([a964cd0](a964cd0)) * Ensure devnet has unproven config ([#11302](#11302)) ([085f782](085f782)) * Fixing `[@safety](https://github.com/safety)` warnings ([#11094](#11094)) ([5de24e0](5de24e0)) * Log correlation in traces in google cloud ([#11276](#11276)) ([fbcc8ef](fbcc8ef)), closes [#11019](#11019) [#10937](#10937) * Mark `noir-edwards` as expected to compile (noir-lang/noir#7085) ([a964cd0](a964cd0)) * Move shared pcs functionality to internal library in solidity and small refactorings in sumcheck ([#11230](#11230)) ([507ae9d](507ae9d)) * Reduce the number of provers in rc-1 ([#11296](#11296)) ([92e40ff](92e40ff)) * Remove references to padding txs ([#11264](#11264)) ([32408f6](32408f6)) * Remove warnings from types and rollup lib crates ([#11269](#11269)) ([9f389a7](9f389a7)) * Replace relative paths to noir-protocol-circuits ([8ece166](8ece166)) * Replace relative paths to noir-protocol-circuits ([be42305](be42305)) * Retry deploys ([#11252](#11252)) ([23cfbb4](23cfbb4)) * Set failed proof store for spartan deployments ([#11282](#11282)) ([f787a52](f787a52)) * Silence "Updated proven chain" log ([#11250](#11250)) ([44bd79b](44bd79b)) * Silence circuit return values in CI ([#11259](#11259)) ([db3d860](db3d860)) * Stable masternet images ([#11289](#11289)) ([07fabe8](07fabe8)) </details> <details><summary>barretenberg: 0.71.0</summary> ## [0.71.0](barretenberg-v0.70.0...barretenberg-v0.71.0) (2025-01-17) ### Bug Fixes * Reallocate commitment key to avoid pippenger error ([#11249](#11249)) ([8fc2011](8fc2011)) * Resolve misc bugs handling phases in avm witgen ([#11218](#11218)) ([29bc4bd](29bc4bd)) ### Miscellaneous * **avm:** Calldata, returndata slices out of range padded with zeros ([#11265](#11265)) ([a469c94](a469c94)), closes [#10933](#10933) * Move shared pcs functionality to internal library in solidity and small refactorings in sumcheck ([#11230](#11230)) ([507ae9d](507ae9d)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

@safety

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.71.0</summary> ## [0.71.0](AztecProtocol/aztec-packages@aztec-package-v0.70.0...aztec-package-v0.71.0) (2025-01-17) ### Features * Track block building helpers ([#11190](AztecProtocol/aztec-packages#11190)) ([a749dc1](AztecProtocol/aztec-packages@a749dc1)), closes [#11184](AztecProtocol/aztec-packages#11184) </details> <details><summary>barretenberg.js: 0.71.0</summary> ## [0.71.0](AztecProtocol/aztec-packages@barretenberg.js-v0.70.0...barretenberg.js-v0.71.0) (2025-01-17) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.71.0</summary> ## [0.71.0](AztecProtocol/aztec-packages@aztec-packages-v0.70.0...aztec-packages-v0.71.0) (2025-01-17) ### ⚠ BREAKING CHANGES * `loop` statements (only frontend) (noir-lang/noir#7092) * Include kind in `StructDefinition::generics` and fix derivation of Eq in structs with numeric generics (noir-lang/noir#7076) * Attestation collection times out based on sequencer timetable ([#11248](AztecProtocol/aztec-packages#11248)) ### Features * `loop` statements (only frontend) (noir-lang/noir#7092) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Add `ConstrainNotEqual` instruction (noir-lang/noir#7032) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Archive public testnet tx data ([#11192](AztecProtocol/aztec-packages#11192)) ([66f2014](AztecProtocol/aztec-packages@66f2014)) * Backup proof failures to google cloud storage ([#11255](AztecProtocol/aztec-packages#11255)) ([b4775fd](AztecProtocol/aztec-packages@b4775fd)), closes [#11062](AztecProtocol/aztec-packages#11062) * **docs:** Algolia->typesense ([#11034](AztecProtocol/aztec-packages#11034)) ([d254f49](AztecProtocol/aztec-packages@d254f49)) * Improve PXE contract DB capabilities ([#11303](AztecProtocol/aztec-packages#11303)) ([fab5570](AztecProtocol/aztec-packages@fab5570)) * **LSP:** Auto-import trait reexport if trait is not visible (noir-lang/noir#7079) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Process note logs in aztec-nr ([#10651](AztecProtocol/aztec-packages#10651)) ([708139d](AztecProtocol/aztec-packages@708139d)) * Reenable constrained config for roots ([#10605](AztecProtocol/aztec-packages#10605)) ([a6ebc2e](AztecProtocol/aztec-packages@a6ebc2e)) * **spartan:** Add extra accounts ([#11300](AztecProtocol/aztec-packages#11300)) ([7782836](AztecProtocol/aztec-packages@7782836)) * **ssa:** Treat globals as constant in a function's DFG (noir-lang/noir#7040) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Track block building helpers ([#11190](AztecProtocol/aztec-packages#11190)) ([a749dc1](AztecProtocol/aztec-packages@a749dc1)), closes [#11184](AztecProtocol/aztec-packages#11184) ### Bug Fixes * Allow implicit associated types on integer type kinds (noir-lang/noir#7078) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Do not remove memory blocks used as brillig input (noir-lang/noir#7073) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Ensure 'docker info' works before preceding ([#11286](AztecProtocol/aztec-packages#11286)) ([0b0e81a](AztecProtocol/aztec-packages@0b0e81a)) * Fail in proxy deployment should fail the step ([#11308](AztecProtocol/aztec-packages#11308)) ([b780d75](AztecProtocol/aztec-packages@b780d75)) * Faster polling times for archiver and sequencer ([#11262](AztecProtocol/aztec-packages#11262)) ([d70511e](AztecProtocol/aztec-packages@d70511e)) * Https://github.com/AztecProtocol/aztec-packages/issues/8939 ([66f2014](AztecProtocol/aztec-packages@66f2014)) * Idempotent deploy-l1-contracts with initial validators ([#11284](AztecProtocol/aztec-packages#11284)) ([3a3f9c0](AztecProtocol/aztec-packages@3a3f9c0)), closes [#11283](AztecProtocol/aztec-packages#11283) * Include kind in `StructDefinition::generics` and fix derivation of Eq in structs with numeric generics (noir-lang/noir#7076) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Legacy runner start ([#11291](AztecProtocol/aztec-packages#11291)) ([0b2a619](AztecProtocol/aztec-packages@0b2a619)) * Reallocate commitment key to avoid pippenger error ([#11249](AztecProtocol/aztec-packages#11249)) ([8fc2011](AztecProtocol/aztec-packages@8fc2011)) * References to a3 in docs ([#11256](AztecProtocol/aztec-packages#11256)) ([caf88fa](AztecProtocol/aztec-packages@caf88fa)) * Remove bb path override in cli-wallet ([#11280](AztecProtocol/aztec-packages#11280)) ([a6a226e](AztecProtocol/aztec-packages@a6a226e)) * Resolve misc bugs handling phases in avm witgen ([#11218](AztecProtocol/aztec-packages#11218)) ([29bc4bd](AztecProtocol/aztec-packages@29bc4bd)) * Sequencer timetable accounts for spare time ([#11221](AztecProtocol/aztec-packages#11221)) ([f1b9211](AztecProtocol/aztec-packages@f1b9211)) * Validator ignores block limits during reexec ([#11288](AztecProtocol/aztec-packages#11288)) ([920a521](AztecProtocol/aztec-packages@920a521)) ### Miscellaneous * Add circuit input checks to bootstrap.sh ([#11261](AztecProtocol/aztec-packages#11261)) ([a718b15](AztecProtocol/aztec-packages@a718b15)) * Add regression test for [#6530](AztecProtocol/aztec-packages#6530) (noir-lang/noir#7089) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Add test for isuee [#7090](AztecProtocol/aztec-packages#7090) (noir-lang/noir#7091) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Allow passing custom conditions to inlining pass (noir-lang/noir#7083) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Attestation collection times out based on sequencer timetable ([#11248](AztecProtocol/aztec-packages#11248)) ([946a418](AztecProtocol/aztec-packages@946a418)) * **avm:** Calldata, returndata slices out of range padded with zeros ([#11265](AztecProtocol/aztec-packages#11265)) ([a469c94](AztecProtocol/aztec-packages@a469c94)), closes [#10933](AztecProtocol/aztec-packages#10933) * Delete external-ci-approved.yml ([#11258](AztecProtocol/aztec-packages#11258)) ([642bce6](AztecProtocol/aztec-packages@642bce6)) * Demote error closing forks to warn ([#11263](AztecProtocol/aztec-packages#11263)) ([a5b7a6a](AztecProtocol/aztec-packages@a5b7a6a)) * Do not make new instruction if it hasn't changed (noir-lang/noir#7069) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Ensure devnet has unproven config ([#11302](AztecProtocol/aztec-packages#11302)) ([085f782](AztecProtocol/aztec-packages@085f782)) * Fixing `[@safety](https://github.com/safety)` warnings ([#11094](AztecProtocol/aztec-packages#11094)) ([5de24e0](AztecProtocol/aztec-packages@5de24e0)) * Log correlation in traces in google cloud ([#11276](AztecProtocol/aztec-packages#11276)) ([fbcc8ef](AztecProtocol/aztec-packages@fbcc8ef)), closes [#11019](AztecProtocol/aztec-packages#11019) [#10937](AztecProtocol/aztec-packages#10937) * Mark `noir-edwards` as expected to compile (noir-lang/noir#7085) ([a964cd0](AztecProtocol/aztec-packages@a964cd0)) * Move shared pcs functionality to internal library in solidity and small refactorings in sumcheck ([#11230](AztecProtocol/aztec-packages#11230)) ([507ae9d](AztecProtocol/aztec-packages@507ae9d)) * Reduce the number of provers in rc-1 ([#11296](AztecProtocol/aztec-packages#11296)) ([92e40ff](AztecProtocol/aztec-packages@92e40ff)) * Remove references to padding txs ([#11264](AztecProtocol/aztec-packages#11264)) ([32408f6](AztecProtocol/aztec-packages@32408f6)) * Remove warnings from types and rollup lib crates ([#11269](AztecProtocol/aztec-packages#11269)) ([9f389a7](AztecProtocol/aztec-packages@9f389a7)) * Replace relative paths to noir-protocol-circuits ([8ece166](AztecProtocol/aztec-packages@8ece166)) * Replace relative paths to noir-protocol-circuits ([be42305](AztecProtocol/aztec-packages@be42305)) * Retry deploys ([#11252](AztecProtocol/aztec-packages#11252)) ([23cfbb4](AztecProtocol/aztec-packages@23cfbb4)) * Set failed proof store for spartan deployments ([#11282](AztecProtocol/aztec-packages#11282)) ([f787a52](AztecProtocol/aztec-packages@f787a52)) * Silence "Updated proven chain" log ([#11250](AztecProtocol/aztec-packages#11250)) ([44bd79b](AztecProtocol/aztec-packages@44bd79b)) * Silence circuit return values in CI ([#11259](AztecProtocol/aztec-packages#11259)) ([db3d860](AztecProtocol/aztec-packages@db3d860)) * Stable masternet images ([#11289](AztecProtocol/aztec-packages#11289)) ([07fabe8](AztecProtocol/aztec-packages@07fabe8)) </details> <details><summary>barretenberg: 0.71.0</summary> ## [0.71.0](AztecProtocol/aztec-packages@barretenberg-v0.70.0...barretenberg-v0.71.0) (2025-01-17) ### Bug Fixes * Reallocate commitment key to avoid pippenger error ([#11249](AztecProtocol/aztec-packages#11249)) ([8fc2011](AztecProtocol/aztec-packages@8fc2011)) * Resolve misc bugs handling phases in avm witgen ([#11218](AztecProtocol/aztec-packages#11218)) ([29bc4bd](AztecProtocol/aztec-packages@29bc4bd)) ### Miscellaneous * **avm:** Calldata, returndata slices out of range padded with zeros ([#11265](AztecProtocol/aztec-packages#11265)) ([a469c94](AztecProtocol/aztec-packages@a469c94)), closes [#10933](AztecProtocol/aztec-packages#10933) * Move shared pcs functionality to internal library in solidity and small refactorings in sumcheck ([#11230](AztecProtocol/aztec-packages#11230)) ([507ae9d](AztecProtocol/aztec-packages@507ae9d)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

nventuro reviewed Jan 7, 2025

View reviewed changes

benesjan force-pushed the 01-07-chore_fixing_aztec-nr_warnings branch from d579beb to e29c345 Compare January 7, 2025 22:07

benesjan changed the title ~~chore: fixing aztec-nr warnings~~ chore: fixing aztec-nr and protocol circuits warnings Jan 7, 2025

benesjan marked this pull request as ready for review January 7, 2025 22:08

benesjan requested review from dbanks12 and fcarreiro as code owners January 7, 2025 22:08

benesjan force-pushed the 01-07-chore_fixing_aztec-nr_warnings branch from e29c345 to 26d8be5 Compare January 8, 2025 02:36

benesjan commented Jan 8, 2025

View reviewed changes

Comment thread noir-projects/aztec-nr/aztec/src/state_vars/shared_mutable/scheduled_delay_change.nr Outdated

benesjan requested review from TomAFrench and nventuro and removed request for dbanks12 and fcarreiro January 8, 2025 03:00

benesjan force-pushed the 01-07-chore_fixing_aztec-nr_warnings branch from 50c83c0 to d9308ca Compare January 8, 2025 18:14

nventuro reviewed Jan 8, 2025

View reviewed changes

benesjan marked this pull request as draft January 8, 2025 18:39

benesjan force-pushed the 01-07-chore_fixing_aztec-nr_warnings branch from 9461346 to 48fb467 Compare January 8, 2025 21:22

benesjan removed the request for review from TomAFrench January 8, 2025 23:02

benesjan added the e2e-all label Jan 8, 2025

benesjan marked this pull request as ready for review January 8, 2025 23:19

benesjan force-pushed the 01-07-chore_fixing_aztec-nr_warnings branch from ca3ec19 to 35f4b12 Compare January 9, 2025 14:38

benesjan mentioned this pull request Jan 9, 2025

refactor: random fixes and readability improvements #11129

Merged

benesjan changed the title ~~chore: fixing aztec-nr and protocol circuits warnings~~ chore: fixing Aztec.nr and protocol circuits @safety warnings Jan 9, 2025

benesjan force-pushed the 01-07-chore_fixing_aztec-nr_warnings branch from 35f4b12 to b7b7b66 Compare January 9, 2025 15:27

benesjan changed the title ~~chore: fixing Aztec.nr and protocol circuits @safety warnings~~ chore: fixing @safety warnings Jan 9, 2025

benesjan requested a review from nventuro January 9, 2025 16:25

benesjan force-pushed the 01-07-chore_fixing_aztec-nr_warnings branch from c9df6c8 to 7e6e87e Compare January 10, 2025 21:43

benesjan marked this pull request as draft January 13, 2025 17:49

benesjan force-pushed the 01-07-chore_fixing_aztec-nr_warnings branch 2 times, most recently from e1f8440 to fc91f1f Compare January 13, 2025 18:12

benesjan marked this pull request as ready for review January 13, 2025 18:29

benesjan mentioned this pull request Jan 13, 2025

chore: require safety doc comment for unsafe instead of //@safety noir-lang/noir#6992

Merged

3 of 5 tasks

benesjan force-pushed the 01-07-chore_fixing_aztec-nr_warnings branch from 3e094bc to 80d9ab4 Compare January 13, 2025 19:14

benesjan added S-blocked Status: Blocked and removed S-blocked Status: Blocked labels Jan 13, 2025

benesjan force-pushed the 01-07-chore_fixing_aztec-nr_warnings branch from 80d9ab4 to 609e9ad Compare January 15, 2025 18:03

spalladino and others added 7 commits January 15, 2025 18:03

fix: Sequencer times out L1 tx at end of L2 slot (#11112)

2d16700

Sets the L1 tx utils timeout to the end of the L2 slot.

new safety comment format

ce20c9c

reverting accidental change

2e3fa0b

WIP

2278530

last touches

6b7b520

better formatting

dbba9ac

fix: triple /

daea821

benesjan force-pushed the 01-07-chore_fixing_aztec-nr_warnings branch from 609e9ad to daea821 Compare January 15, 2025 18:04

nventuro approved these changes Jan 15, 2025

View reviewed changes

nventuro merged commit 5de24e0 into master Jan 15, 2025

nventuro deleted the 01-07-chore_fixing_aztec-nr_warnings branch January 15, 2025 19:07

AztecBot mentioned this pull request Jan 15, 2025

chore(master): Release 0.71.0 #11247

Merged

Conversation

benesjan commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note for reviewer

Uh oh!

benesjan commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nventuro Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

fcarreiro Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nventuro Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

benesjan Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

TomAFrench Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

benesjan Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomAFrench Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

benesjan Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

benesjan Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomAFrench commented Jan 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomAFrench commented Jan 9, 2025

Uh oh!

benesjan commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomAFrench commented Jan 10, 2025

Uh oh!

TomAFrench commented Jan 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

benesjan commented Jan 7, 2025 •

edited

Loading

benesjan commented Jan 7, 2025 •

edited

Loading

fcarreiro Jan 8, 2025 •

edited

Loading

benesjan Jan 8, 2025 •

edited

Loading

benesjan commented Jan 10, 2025 •

edited

Loading