Repository navigation
refactor!: note interfaces - #12106
Conversation
87bf0e8 to
958aca1
Compare
21d1e1c to
a004487
Compare
There was a problem hiding this comment.
Nuke the test link because I nuked the test because it was some stale thing that made no sense.
ea68afa to
15d71a3
Compare
15d71a3 to
c9a156d
Compare
There was a problem hiding this comment.
Renamed this to implementing a note and largely rewrote that as it was very stale.
There was a problem hiding this comment.
Just applied formatting here.
There was a problem hiding this comment.
Here is where real changes begin.
There was a problem hiding this comment.
This just contained an unused import
There was a problem hiding this comment.
Sneaked this in (Nico 😝) - we relied on VALUE_NOTE_LEN being exported which is an anti-pattern.
There was a problem hiding this comment.
Sneaked this in (Nico 😝) - we relied on VALUE_NOTE_LEN being exported which is an anti-pattern. On top of that now it could cause a problem if the derived Packable impl. did not match it.
There was a problem hiding this comment.
This was just used in one test which made zero sense so I just nuked it all.
There was a problem hiding this comment.
This test was just weird - it contains just one test case which looks useless at this point and the test case has nothing to do with non_contract_accounts. So I just nuked it all.
There was a problem hiding this comment.
This test seems like a non-sense. It does nothing with messaging!
This test case was first created 20 months ago and I think it has been updated like 426 times in a negligent way that it became something completely different. So I nuked it
79e5879 to
d724762
Compare
There was a problem hiding this comment.
Sneaked changes in this file in (Nico 😝) - we relied on CARD_NOTE_LEN being exported which is an anti-pattern.
There was a problem hiding this comment.
The Serialize trait impl. was unused here so I nuked it.
7f791ad to
7bcada0
Compare
3f3f111 to
cf57f73
Compare
0914eaa to
4690b3d
Compare
| ) -> [u8; N * 32 + 64] | ||
| where | ||
| Note: NoteInterface + Packable<N>, | ||
| Note: NoteType + Packable<N>, |
There was a problem hiding this comment.
Been thinking for a while now that this should be NOTE, not Note. Note looks like a type, and we always use caps for generics in other places.
There was a problem hiding this comment.
e.g. below Note::get_id() looks quite confusing - as if Note was a trait, which also sounds quite reasonable.
There was a problem hiding this comment.
Agree. Created an issue and I will tackle it once we get our note-related PRs merged.
cea2e92 to
e1c19b9
Compare
62a0c50 to
f6e1600
Compare
f6e1600 to
5b28f84
Compare
* master: (92 commits) chore: Log prover publisher address on creation (#12267) feat: https for bootnode in devnet (#12161) feat(avm): support shifts in lookups (#12280) feat(docs): Add flamegraph tool to counter contract tutorial (#12202) feat(spartan): 192 node 1 tps - additional validator service (#12238) feat(avm): class id derivation (#12263) docs: Fees doc snippets and code snippets (#12229) refactor: proving cost in fee header (#12048) fix: prometheus scrapes itself in the cluster (#12277) feat: metrics (#12256) chore: cleanup stdlib internal imports (#12274) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: Enforce no import side effects (#12268) refactor!: note interfaces (#12106) yolo undenoise tests feat: new transcript functionality to hash elements without including in proof (#12233) chore: remove gcloud metrics (#12265) ...
3 participants
Fixes #12012
Implements a solution described in this comment