Skip to content

feat(barretenberg): Graph methods for circuit analysis (part 2) - #12110

Closed
DanielKotov wants to merge 49 commits into
masterfrom
dk/boomerang_value_detection_part2_final
Closed

DanielKotov wants to merge 49 commits into
masterfrom
dk/boomerang_value_detection_part2_final

Conversation

@DanielKotov

Copy link
Copy Markdown
Contributor

This PR continues Graph Description for Ultra Circuit Builder.

There were added functions for processing:

  1. auxiliary block (bigfield limb accumulation, bigfield product, RAM/ROM tables read gates)
  2. poseidon2s external and internal blocks.

There were tested primitives like Poseidon2s hash function, Dynamic Array and Bigfield. Poseidon and Dynamic Array have been fully tested. Bigfield has been tested halfway.

There has been completed function for arithmetic block. (q_arith == 3 case), and it processes fix_witness another way.

There was added new filtering mechanism for finalize_circuit() function using tau and range tags, filtering mechanism for RAM/ROM gate and filtering mechanism for variables that were fixed.

Also there was added new data structure for containing information about gates for every variable. It can be helpful in further filtering mechanisms or debugging process.

No vulnerabilities were found by static analyzer.

DanielKotov and others added 30 commits October 2, 2024 16:43
@Rumata888 Rumata888 changed the title feat: Graph methods for circuit analysis (part 2) feat: Graph methods for circuit analysis (part 2) Feb 19, 2025
@Rumata888 Rumata888 changed the title feat: Graph methods for circuit analysis (part 2) feat(barretenberg): Graph methods for circuit analysis (part 2) Feb 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you renamed all of these?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consist of

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need comments

@DanielKotov
DanielKotov force-pushed the dk/boomerang_value_detection_part2_final branch from 313b5d6 to 29ff134 Compare February 20, 2025 06:32
@Rumata888

Copy link
Copy Markdown
Contributor

Replaced with #12130

@Rumata888 Rumata888 closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants