Skip to content

feat: example contracts in aztec.js - #1395

Closed
benesjan wants to merge 2 commits into
masterfrom
janb/example-contracts-in-aztec-js
Closed

feat: example contracts in aztec.js#1395
benesjan wants to merge 2 commits into
masterfrom
janb/example-contracts-in-aztec-js

Conversation

@benesjan

@benesjan benesjan commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

Fixes #1306

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@benesjan
benesjan force-pushed the janb/example-contracts-in-aztec-js branch from 88ded60 to 8210a4b Compare August 3, 2023 11:13
@benesjan
benesjan enabled auto-merge (squash) August 3, 2023 11:33
@@ -0,0 +1,119 @@
/* eslint-disable */

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can these be symlinked instead, this could be a footgun when stuff changes underfoot

@@ -0,0 +1,384 @@
{

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file required

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally committed it. Thanks

@spalladino

Copy link
Copy Markdown
Contributor

I fear we may end up with these example contracts out of date, which is a problem considering how fast noir is shipping breaking changes. Maybe we should tweak copy_output in Noir compiler so it copies these artifacts to aztec.js as well? We're already doing so for the account contract ABIs IIRC. Now, if we do that, the tricky thing will be to do it without committing the built artifacts, so we don't start hitting conflicts again, but perhaps we can gloss over that for now.

An alternative could be to ship the examples separately, and just make them easier to import via path remappings or something, but it's true that it's not what the issue asked for in the first place.

@benesjan
benesjan disabled auto-merge August 3, 2023 12:00
@benesjan
benesjan marked this pull request as draft August 3, 2023 12:06
@benesjan benesjan closed this Aug 3, 2023
@benesjan
benesjan deleted the janb/example-contracts-in-aztec-js branch August 3, 2023 12:13
codygunton pushed a commit that referenced this pull request Jan 23, 2024
ludamad pushed a commit that referenced this pull request Feb 27, 2026
## Summary

- Parallelizes `PrivateExecutionSteps::parse()` — deserializes each
step's ACIR bytecode and witness data in parallel using `parallel_for`
- Parallelizes `PrivateExecutionStepRaw::load_and_decompress()` —
decompresses gzip data for each step in parallel

Closes #1395

[ClaudeBox
log](http://ci.aztec-labs.com/6987e2365fae49247e056cb7a95c3578)
johnathan79717 pushed a commit that referenced this pull request Mar 4, 2026
## Summary

- Parallelizes `PrivateExecutionSteps::parse()` — deserializes each
step's ACIR bytecode and witness data in parallel using `parallel_for`
- Parallelizes `PrivateExecutionStepRaw::load_and_decompress()` —
decompresses gzip data for each step in parallel

Closes #1395

[ClaudeBox
log](http://ci.aztec-labs.com/6987e2365fae49247e056cb7a95c3578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Add a couple of example contracts to aztec.js

3 participants