Added checks for lhs and rhs in pedersen.ts - #157
Merged
Conversation
Collaborator
|
Thanks for this! May as well check that it is exactly 32. We will read 32 bytes unconditionally, and while an overflow is more problematic, we don't want to read garbage data either. |
Contributor
Author
|
Yeah of course, I'll make the changes. |
ludamad
approved these changes
Apr 4, 2023
ludamad
pushed a commit
that referenced
this pull request
Jul 14, 2023
codygunton
added a commit
that referenced
this pull request
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #149
Added a check to ensure that the length of lhs and rhs do not exceed 32 bytes.