fix: build after foundation refactor - #159
Merged
Merged
Conversation
ludamad
changed the title
sirasistant
approved these changes
Apr 4, 2023
spalladino
approved these changes
Apr 4, 2023
spalladino
left a comment
spalladino
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing the build!
Comment on lines
+6
to
+12
| "prepare": "workspaces-to-typescript-project-references --tsconfigPath tsconfig.dest.json && prettier -w */tsconfig.dest.json", | ||
| "docs": "typedoc --out docs/dist && cd docs && yarn serve", | ||
| "formatting": "yarn workspaces foreach run formatting", | ||
| "formatting:fix": "yarn workspaces foreach run formatting:fix", | ||
| "build": "yarn workspaces foreach run build" | ||
| "formatting": "yarn workspaces foreach -v run formatting", | ||
| "formatting:fix": "yarn workspaces foreach -v run formatting:fix", | ||
| "test": "yarn workspaces foreach -v run test", | ||
| "build": "tsc -b tsconfig.dest.json", | ||
| "build:dev": "tsc -b tsconfig.dest.json --watch" |
Contributor
There was a problem hiding this comment.
This doesn't look like part of the fix, but I love it. Thanks for working on it!
Collaborator
Author
There was a problem hiding this comment.
Not directly, but porting some of these changes made it nicer to fix :)
ludamad
pushed a commit
that referenced
this pull request
Jul 14, 2023
#159) * split witness out, deprecate poly manifest, unify sumcheck pcs inputs, WiP but all tests passing * minor updates * cleanup and rebase fixes * split up wires and z perm in prover * making sumcheck related tests use enum for poly ordering * remove poly manifest from prover tests * make two more test suites rely on enum for poly ordering * making verifier properly depend on enum * fixed one more test, enum can now be permuted arbitrarily up to category * automating claim construction in verifier * completely removing Multivariates * attempt to fix build error in CCI * remove honk poly manifest altogether * witness properly moved from composer helper to prover * fix bad access of wires in pkey in some tests * adding comments and doing some general cleanup
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
#159) * split witness out, deprecate poly manifest, unify sumcheck pcs inputs, WiP but all tests passing * minor updates * cleanup and rebase fixes * split up wires and z perm in prover * making sumcheck related tests use enum for poly ordering * remove poly manifest from prover tests * make two more test suites rely on enum for poly ordering * making verifier properly depend on enum * fixed one more test, enum can now be permuted arbitrarily up to category * automating claim construction in verifier * completely removing Multivariates * attempt to fix build error in CCI * remove honk poly manifest altogether * witness properly moved from composer helper to prover * fix bad access of wires in pkey in some tests * adding comments and doing some general cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the build. Improvements to bootstrap.sh.
Checklist: