feat: auto-close issues from merge commits to default branch - #17828
Merged
Conversation
ludamad
force-pushed
the
ad/feat/auto-close-issues-from-merge-commits
branch
12 times, most recently
from
October 20, 2025 21:42
c341975 to
f976ea3
Compare
ludamad
enabled auto-merge
October 20, 2025 21:58
AztecBot
force-pushed
the
ad/feat/auto-close-issues-from-merge-commits
branch
from
October 20, 2025 22:02
f976ea3 to
c5f24e2
Compare
AztecBot
force-pushed
the
ad/feat/auto-close-issues-from-merge-commits
branch
from
October 20, 2025 22:05
c5f24e2 to
47b7bf6
Compare
sirasistant
approved these changes
Oct 21, 2025
sirasistant
left a comment
sirasistant
left a comment
Contributor
There was a problem hiding this comment.
LGTM only nit from me is for it to pick the url form also not only the #issue number form
ludamad
force-pushed
the
ad/feat/auto-close-issues-from-merge-commits
branch
from
October 23, 2025 16:28
47b7bf6 to
f3355ee
Compare
ludamad
requested review from
a team,
IlyasRidhuan,
LHerskind,
LeilaWang,
Maddiaa0,
fcarreiro,
jeanmon and
just-mitch
as code owners
October 23, 2025 16:28
ludamad
removed request for
a team,
IlyasRidhuan,
LHerskind,
LeilaWang,
Maddiaa0,
charlielye,
fcarreiro,
jeanmon and
just-mitch
October 23, 2025 21:01
ludamad
force-pushed
the
ad/feat/auto-close-issues-from-merge-commits
branch
from
October 23, 2025 21:02
f4f0bf2 to
03981ca
Compare
ludamad
enabled auto-merge
October 23, 2025 21:17
## Problem When PRs target intermediate branches (e.g., merge-train) instead of the main branch, GitHub's native auto-close functionality doesn't work. Issues referenced with `Closes #123` remain open even after the PR eventually merges to `next`. Recognizes cross-repo references and various `resolves` `fixes` etc
AztecBot
force-pushed
the
ad/feat/auto-close-issues-from-merge-commits
branch
from
October 23, 2025 21:19
03981ca to
7babc80
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 23, 2025
ludamad
added a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When PRs target intermediate branches (e.g., merge-train) instead of the main branch, GitHub's native auto-close functionality doesn't work. Issues referenced with
Closes #123remain open even after the PR eventually merges tonext.Recognizes cross-repo references and various
resolvesfixesetc