Skip to content

WIP: Milestone 1.4 - #183

Closed
sirasistant wants to merge 19 commits into
masterfrom
arv/milestone-1-4
Closed

WIP: Milestone 1.4#183
sirasistant wants to merge 19 commits into
masterfrom
arv/milestone-1-4

Conversation

@sirasistant

@sirasistant sirasistant commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Description

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

sirasistant
sirasistant commented Apr 5, 2023
View reviewed changes
Comment thread yarn-project/circuits.js/src/abis/abis.ts Outdated
wasm.writeMemory(0, leafPreimage.toBuffer());
await wasm.asyncCall('abis__compute_contract_leaf', 0, data.length);
return Buffer.from(wasm.getMemorySlice(data.length, data.length + 32));
export async function computeContractLeaf(wasm: CircuitsWasm, newContractData: NewContractData) {

@sirasistant sirasistant Apr 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an issue in the abis__compute_contract_leaf, if we use it, It won't match the rollup circuit value

LeilaWang
LeilaWang reviewed Apr 5, 2023
View reviewed changes
Comment thread yarn-project/circuits.js/src/abis/abis.ts Outdated
LeilaWang
LeilaWang reviewed Apr 5, 2023
View reviewed changes
Comment thread yarn-project/end-to-end/src/e2e_zk_token_contract.test.ts
ludamad pushed a commit that referenced this pull request Apr 14, 2023
@LHerskind @rahul-kothari
feat: reusable rollup components (#183)
bb87daf 
* add rollup subtree height

* just use one type of public inputs for base/merge (#168)

* fix: re-usable rollup components

* fix: hash_multiple -> hash_pair_native

---------

Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@LHerskind @rahul-kothari @ludamad
feat: reusable rollup components (#183)
53dff4f 
* add rollup subtree height

* just use one type of public inputs for base/merge (#168)

* fix: re-usable rollup components

* fix: hash_multiple -> hash_pair_native

---------

Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@LHerskind @rahul-kothari @ludamad
feat: reusable rollup components (#183)
c36d74e 
* add rollup subtree height

* just use one type of public inputs for base/merge (#168)

* fix: re-usable rollup components

* fix: hash_multiple -> hash_pair_native

---------

Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
@sirasistant
sirasistant deleted the arv/milestone-1-4 branch April 27, 2023 12:03
rangozd pushed a commit to rangozd/aztec-packages that referenced this pull request Aug 5, 2026
@notnotraju
Merge pull request AztecProtocol#183 from AztecProtocol/rk/wasm-simd-…
e4b7b90 
…03-accumulator

feat(polynomials): [PR03] Accumulator<Fr> reduction adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeilaWang LeilaWang LeilaWang left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sirasistant @LeilaWang @PhilWindle