fix: use actual data extent for CommitmentKey in HypernovaDeciderProver - #21206
Merged
Conversation
After PR #21179 optimized `compute_new_claim()` to move polynomials instead of copying, the `virtual_size()` of accumulator polynomials no longer reliably reflects the accumulator's dyadic size. Use the explicit `dyadic_size` field which is always set correctly. This fixes WASM chonk integration tests that failed because `virtual_size()` returned 2^21 (CONST_FOLDING_LOG_N) causing CommitmentKey to request more CRS points than available.
Use `end_index()` to compute the tightest CRS size needed, rather than `dyadic_size` (which can be 2^21). Pass `dyadic_size` to the batcher and Shplemini (which need the multilinear domain size) but only request as many CRS points as the polynomial data actually requires.
johnathan79717
changed the title
ludamad
approved these changes
Mar 6, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
BEGIN_COMMIT_OVERRIDE fix: add -g0 to zig presets to eliminate 11GB debug info bloat (#21071) fix: resolve flaky p2p_client test race condition on ARM64 (#21088) chore: remove domain iteration macros and address backing memory race (#20988) fix: [ECCVM] added domain separation for the multiset equality check. (#20352) feat: hybrid CRS hash verification — 8MB chunks, parallel, span-based (#21113) chore: unify splitting scalars interface (#20805) chore: add a unique id to each origin tag (#20924) chore: Native curve audit (#20936) chore: Update bootstrap in test vk haven't changed script (#21153) fix: use reduced form in WASM FromMontgomeryForm test (#21164) chore: erase ephemeral secrets from memory in schnorr and aes (#21106) chore: suppress clangd target triple version diagnostic (#21180) feat: Optimise new claim calculation (#21179) docs: add Quick Start build instructions to barretenberg README (#20951) feat: batched chonk verification (#21083) fix: link libc++ instead of libstdc++ for Rust FFI on Linux (#21203) fix: [ECCVM] in the transcript table, no-ops force the next accumulator to be 0. (#20849) fix: resolve merge-train conflict with next (zig wrapper scripts + -g0) (#21201) fix: [ECCVM] rare edge case completeness issue when `z1 == 0` but `z2 != 0` (#20858) fix: use actual data extent for CommitmentKey in HypernovaDeciderProver (#21206) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute_new_claim()to move polynomials instead of copying,virtual_size()on accumulator polynomials no longer reliably equals the accumulator's dyadic size.HypernovaDeciderProver::construct_proofusedvirtual_size()to create aCommitmentKey, which could request 2^21 CRS points — exceeding the WASM default of 2^20.end_index()to compute the tightest CRS size for theCommitmentKey, while passingdyadic_sizetoPolynomialBatcherandShpleminiProverwhich need the multilinear domain size.Test plan
hypernova_testspass (9/9)chonk_testspass (25/25)