Skip to content

fix: catch exceptions in ChonkBatchVerifier::batch_check #22270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnathan79717 merged 1 commit into from
Apr 2, 2026
Merged

fix: catch exceptions in ChonkBatchVerifier::batch_check #22270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions barretenberg/cpp/src/barretenberg/chonk/chonk_batch_verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,18 +216,23 @@ bool ChonkBatchVerifier::batch_check(const std::vector<ReduceResult>& results, c

set_parallel_for_concurrency(num_cores_);

// Collect IPA claims and transcripts for batch verification
std::vector<OpeningClaim<curve::Grumpkin>> claims;
std::vector<std::shared_ptr<NativeTranscript>> transcripts;
claims.reserve(indices.size());
transcripts.reserve(indices.size());
for (size_t idx : indices) {
claims.push_back(results[idx].ipa_claim);
transcripts.push_back(std::make_shared<NativeTranscript>(results[idx].ipa_proof));
}
try {
// Collect IPA claims and transcripts for batch verification
std::vector<OpeningClaim<curve::Grumpkin>> claims;
std::vector<std::shared_ptr<NativeTranscript>> transcripts;
claims.reserve(indices.size());
transcripts.reserve(indices.size());
for (size_t idx : indices) {
claims.push_back(results[idx].ipa_claim);
transcripts.push_back(std::make_shared<NativeTranscript>(results[idx].ipa_proof));
}

auto ipa_vk = VerifierCommitmentKey<curve::Grumpkin>{ ECCVMFlavor::ECCVM_FIXED_SIZE };
return IPA<curve::Grumpkin>::batch_reduce_verify(ipa_vk, claims, transcripts);
auto ipa_vk = VerifierCommitmentKey<curve::Grumpkin>{ ECCVMFlavor::ECCVM_FIXED_SIZE };
return IPA<curve::Grumpkin>::batch_reduce_verify(ipa_vk, claims, transcripts);
} catch (const std::exception& e) {
info("ChonkBatchVerifier: batch_check exception: ", e.what());
return false;
}
}

void ChonkBatchVerifier::bisect(std::vector<ReduceResult>& results,
Expand Down
Loading