chore: basic K=2 Poseidon2 compression - #22671
Open
AztecBot wants to merge 21 commits into
Open
Conversation
- CHONK_PROOF_LENGTH: 1332 -> 1317 (MegaZKFlavor::NUM_ALL_ENTITIES delta from databus genericization on merge-train after PR #22652's base) - mock_verifier_inputs.test.cpp static_assert - noir constants.nr - yarn-project constants.gen.ts - hypernova_verifier.test.cpp: drop stale {CALLDATA,SECONDARY_CALLDATA, RETURN_DATA}_READ_TAGS entries from Round 0 of expected manifest (databus no longer sends read_tags per-bus-column) - rollup-tx-base-private/Prover.toml: trim 15 trailing zero entries from inputs.hiding_kernel_proof_data.proof (1332 -> 1317) bb tests: 61/61 binaries pass (552/552 dsl_tests with 7 pre-existing GTEST_SKIP; pinned VK-hash script not run per request)
iakovenkos
marked this pull request as ready for review
April 20, 2026 18:29
…laudebox/poseidon2-k2-basic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts commits from #22652 up to and including
8e36689— i.e. the most basic K=2 Poseidon2 compression impl, without the more aggressive compression / extra-wires variants.Commits included (6, cherry-picked onto current
merge-train/barretenberg)abb6ebb7200a167ea11c3be85a868b50172ade9d64aae9d9e98e36689d5dThe merge commit
3c1450bde7from the original PR was skipped (this branch is rebased onto currentmerge-train/barretenberginstead).Conflicts resolved
Several conflicts arose vs current
merge-train/barretenberg(which is ahead of the PR's original merge based2eb0fa3). All were resolved in favor of the PR side:gate_count_constants.hpp— PR side; later overwritten by8e36689mock_verifier_inputs.test.cpp—CHONK_PROOF_LENGTH = 1332hypernova_verifier.test.cpp— usesMegaFlavor::NUM_ALL_ENTITIESconstants.nr/constants.gen.ts— PR sidetest_chonk_standalone_vks_havent_changed.sh— PR side; later overwrittenProver.toml— PR side (extra zero-padding)gate_count_constants.hpp(final cherry-pick) — manually merged following PR's own resolution in3c1450bd: kept bothreturn std::make_tuple(771540, 0);andreturn std::make_tuple(786171, 0);(first line unreachable, matching original PR state at8e36689)Detailed extraction notes: https://gist.github.com/AztecBot/4ffc77e0101f43a41e4a9cf5ba20f71d
No build or tests were run — extraction-only PR per request.
ClaudeBox log: https://claudebox.work/s/3ac5703a07190415?run=1