Skip to content

chore: basic K=2 Poseidon2 compression - #22671

Open
AztecBot wants to merge 21 commits into
merge-train/barretenbergfrom
claudebox/poseidon2-k2-basic
Open

chore: basic K=2 Poseidon2 compression#22671
AztecBot wants to merge 21 commits into
merge-train/barretenbergfrom
claudebox/poseidon2-k2-basic

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Extracts commits from #22652 up to and including 8e36689 — i.e. the most basic K=2 Poseidon2 compression impl, without the more aggressive compression / extra-wires variants.

Commits included (6, cherry-picked onto current merge-train/barretenberg)

Original SHA Subject
abb6ebb720 telescopic poseidon
0a167ea11c upd constants
3be85a868b mega vk length upd
50172ade9d upd ts consts
64aae9d9e9 vk hash + toml upd
8e36689d5d upd

The merge commit 3c1450bde7 from the original PR was skipped (this branch is rebased onto current merge-train/barretenberg instead).

Conflicts resolved

Several conflicts arose vs current merge-train/barretenberg (which is ahead of the PR's original merge base d2eb0fa3). All were resolved in favor of the PR side:

  • gate_count_constants.hpp — PR side; later overwritten by 8e36689
  • mock_verifier_inputs.test.cppCHONK_PROOF_LENGTH = 1332
  • hypernova_verifier.test.cpp — uses MegaFlavor::NUM_ALL_ENTITIES
  • constants.nr / constants.gen.ts — PR side
  • test_chonk_standalone_vks_havent_changed.sh — PR side; later overwritten
  • Prover.toml — PR side (extra zero-padding)
  • gate_count_constants.hpp (final cherry-pick) — manually merged following PR's own resolution in 3c1450bd: kept both return std::make_tuple(771540, 0); and return std::make_tuple(786171, 0); (first line unreachable, matching original PR state at 8e36689)

Detailed extraction notes: https://gist.github.com/AztecBot/4ffc77e0101f43a41e4a9cf5ba20f71d

No build or tests were run — extraction-only PR per request.

ClaudeBox log: https://claudebox.work/s/3ac5703a07190415?run=1

(cherry picked from commit abb6ebb)
(cherry picked from commit 0a167ea)
(cherry picked from commit 3be85a8)
(cherry picked from commit 50172ad)
(cherry picked from commit 64aae9d)
(cherry picked from commit 8e36689)
@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Apr 20, 2026
- CHONK_PROOF_LENGTH: 1332 -> 1317 (MegaZKFlavor::NUM_ALL_ENTITIES delta
  from databus genericization on merge-train after PR #22652's base)
  - mock_verifier_inputs.test.cpp static_assert
  - noir constants.nr
  - yarn-project constants.gen.ts
- hypernova_verifier.test.cpp: drop stale {CALLDATA,SECONDARY_CALLDATA,
  RETURN_DATA}_READ_TAGS entries from Round 0 of expected manifest
  (databus no longer sends read_tags per-bus-column)
- rollup-tx-base-private/Prover.toml: trim 15 trailing zero entries from
  inputs.hiding_kernel_proof_data.proof (1332 -> 1317)

bb tests: 61/61 binaries pass (552/552 dsl_tests with 7 pre-existing
GTEST_SKIP; pinned VK-hash script not run per request)
@iakovenkos
iakovenkos marked this pull request as ready for review April 20, 2026 18:29
@iakovenkos
iakovenkos requested a review from LeilaWang as a code owner April 20, 2026 18:29
@iakovenkos iakovenkos added ci-full Run all master checks. and removed ci-draft Run CI on draft PRs. labels Apr 20, 2026
@iakovenkos iakovenkos changed the title chore: extract basic K=2 Poseidon2 compression from #22652 (up to 8e36689) chore: basic K=2 Poseidon2 compression Apr 20, 2026
@iakovenkos iakovenkos self-assigned this Apr 21, 2026
@iakovenkos iakovenkos added no-cache Disable CI cache and removed ci-full Run all master checks. no-cache Disable CI cache claudebox Owned by claudebox. it can push to this PR. labels Apr 21, 2026
@iakovenkos iakovenkos added the ci-full Run all master checks. label Apr 21, 2026
@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-full Run all master checks. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants