feat(standard-contracts): add v4-style pin-build mechanism for standard contracts - #23262
Merged
dbanks12 merged 6 commits intoMay 29, 2026
Merged
Conversation
This was referenced May 13, 2026
Contributor
Author
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
from
May 14, 2026 13:42
d2f6d24 to
c662d17
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
from
May 14, 2026 13:42
966fca5 to
3702cda
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
from
May 14, 2026 14:18
c662d17 to
e4f8cb3
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
2 times, most recently
from
May 14, 2026 19:26
c291b97 to
91cba07
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
2 times, most recently
from
May 14, 2026 19:37
2a01c1e to
7e4e2fa
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
2 times, most recently
from
May 14, 2026 19:45
991fe58 to
c312b64
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
2 times, most recently
from
May 14, 2026 20:04
b584d56 to
6fee021
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
2 times, most recently
from
May 14, 2026 20:48
536846d to
bded191
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
2 times, most recently
from
May 14, 2026 22:17
3ebe06c to
d17d039
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
2 times, most recently
from
May 15, 2026 17:33
1e72115 to
948ba98
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
from
May 15, 2026 17:33
d17d039 to
4fd03ac
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
from
May 15, 2026 19:27
948ba98 to
30edb2f
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
from
May 15, 2026 19:27
4fd03ac to
6bda65c
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
from
May 15, 2026 19:37
30edb2f to
9f8bb05
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
from
May 15, 2026 19:37
6bda65c to
98cbab1
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
from
May 17, 2026 00:24
9f8bb05 to
7e52403
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
2 times, most recently
from
May 17, 2026 10:16
2b5e859 to
4a6f95e
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
from
May 26, 2026 19:52
ec369c8 to
86793e4
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
2 times, most recently
from
May 26, 2026 20:11
9e247a0 to
77567be
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
2 times, most recently
from
May 26, 2026 20:15
6c73e70 to
f4072aa
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
2 times, most recently
from
May 26, 2026 20:36
22d9842 to
b17d197
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
from
May 26, 2026 20:36
f4072aa to
2b125a3
Compare
dbanks12
marked this pull request as ready for review
May 26, 2026 20:43
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
from
May 26, 2026 20:47
2b125a3 to
7dae34b
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
from
May 26, 2026 20:47
b17d197 to
5c65007
Compare
ludamad
approved these changes
May 26, 2026
ludamad
left a comment
ludamad
left a comment
Collaborator
There was a problem hiding this comment.
not clear on context but change lgtm
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
from
May 27, 2026 13:57
5c65007 to
f753b35
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
2 times, most recently
from
May 27, 2026 15:36
e2a8c32 to
4575e3e
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
2 times, most recently
from
May 27, 2026 15:40
13d5fb1 to
edb083a
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
from
May 27, 2026 15:59
030e647 to
60cec89
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
from
May 27, 2026 16:00
edb083a to
05bdadb
Compare
dbanks12
force-pushed
the
dbanks12/shift-protocol-addresses
branch
from
May 27, 2026 16:08
60cec89 to
d0fd90e
Compare
dbanks12
force-pushed
the
dbanks12/standard-contracts-pin-artifacts
branch
2 times, most recently
from
May 27, 2026 16:19
5f3928b to
ed52afb
Compare
…eproducibility check
…ne iterating file Replaces three near-identical per-contract reproducibility.test.ts files with a single src/reproducibility.test.ts that iterates standardContracts[] from contract_data.ts. Pinned artifacts move from src/<slug>/pinned/ to a flat src/pinned/ directory. Adding a new standard contract is now strictly one row in standardContracts[] plus one pinned JSON; no test-file edits needed.
…arball substitution
Replaces the per-contract pinned JSON + sha256 reproducibility test with the same
mechanism v4 uses for protocol contracts: a single committed
pinned-standard-contracts.tar.gz whose presence at build time causes
noir-contracts/bootstrap.sh to extract the pinned artifacts into target/ and skip
recompilation of contracts under contracts/standard/.
The tarball is intentionally not committed in this PR. Its absence makes the
extraction block a no-op on next; the mechanism activates when a release branch
(e.g. v5) is cut and someone runs `./bootstrap.sh pin-standard-build` and commits
the resulting tarball.
Adds:
- noir-projects/noir-contracts/standard_contracts.json (manifest mirroring
protocol_contracts.json)
- extraction block in build() gated on tarball presence
- pin-standard-build function + case arm
Removes:
- yarn-project/standard-contracts/src/reproducibility.test.ts
- yarn-project/standard-contracts/src/pinned/*.json (three pinned artifacts)
- the matching .prettierignore entry
Commit pinned-standard-contracts.tar.gz so the standard contracts (AuthRegistry, MultiCallEntrypoint, PublicChecks) are pinned: the build extracts the canonical artifacts instead of recompiling, freezing their deterministic addresses on next. Verified the pinned artifacts reproduce the committed standard_contract_data.ts / standard_addresses.nr values (no drift).
… preloading The multicall-demotion migration note referenced `registerMultiCallEntrypoint`, which the final PR replaced with the `preloadedContractsProvider` option on PXECreationOptions. Correct the multi_call_entrypoint and auth_registry TBD notes to describe the actual mechanism: createPXE preloads the MultiCallEntrypoint by default, EmbeddedWallet preloads MultiCallEntrypoint + AuthRegistry, and other PXE consumers can supply their own preloadedContractsProvider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the protocol-contract pinning mechanism v4 uses (
pinned-protocol-contracts.tar.gz), but for standard contracts.noir-contracts/bootstrap.shextractspinned-standard-contracts.tar.gzintotarget/at build time when present, and skips recompilation ofcontracts/standard/*.noir-contracts/bootstrap.sh pin-standard-buildforce-builds the standard contracts and produces the tarball, intended to be run by a human at release-branch cut.noir-contracts/standard_contracts.jsonlists the artifact names included in the tarball (mirror ofprotocol_contracts.json).The tarball is intentionally not committed in this PR. Its absence makes the extraction block a no-op on
next; the mechanism activates only when a release branch (e.g.v5) is cut and someone runs./bootstrap.sh pin-standard-buildand commits the resulting tarball.