Enabled multiple tests against same rollup contract - #233
Closed
PhilWindle wants to merge 1 commit into
Closed
Conversation
6 tasks
Contributor
|
closing off the back of this comment #240 (comment) |
ludamad
pushed a commit
that referenced
this pull request
Apr 14, 2023
* zero-initialize all abi and kernel structs. helper function to zero-init arrays of frs * revert uint32 assignments to 0 * better struct initialization in app circuits files * revert bad zero init of string * dont need to do as much in base utils since structs are sanely zero-initialized * format comment fix * use fill to initialize array of fields to zero
ludamad
pushed a commit
that referenced
this pull request
Apr 17, 2023
* zero-initialize all abi and kernel structs. helper function to zero-init arrays of frs * revert uint32 assignments to 0 * better struct initialization in app circuits files * revert bad zero init of string * dont need to do as much in base utils since structs are sanely zero-initialized * format comment fix * use fill to initialize array of fields to zero
ludamad
pushed a commit
that referenced
this pull request
Apr 17, 2023
* zero-initialize all abi and kernel structs. helper function to zero-init arrays of frs * revert uint32 assignments to 0 * better struct initialization in app circuits files * revert bad zero init of string * dont need to do as much in base utils since structs are sanely zero-initialized * format comment fix * use fill to initialize array of fields to zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist: