feat: allow registration of raw shared secrets - #23708
Merged
nchamo merged 1 commit intoJun 22, 2026
Merged
Conversation
nchamo
reviewed
Jun 1, 2026
nchamo
left a comment
nchamo
left a comment
Contributor
There was a problem hiding this comment.
As part of the constrained delivery work, we want to support interactive handshakes. When two users perform this type of handshake, the recipient is meant to store that secret on their PXE, so that they listen for future messages
I think it makes sense to first discuss how we'll support interactive handshakes, because we could merge registerSharedSecret with that workflow
Contributor
Author
|
Yeah agreed. Probably the only thing we'll end up merging from this are the changes to the store and to the derivation functions, not the PXE entrypoint. |
nchamo
changed the base branch from
merge-train/fairies
to
merge-train/fairies-v5
June 22, 2026 18:04
nchamo
force-pushed
the
nico/allow-shared-secret-registration
branch
from
June 22, 2026 18:44
2c10771 to
0326051
Compare
nchamo
self-requested a review
June 22, 2026 18:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a second source for log tags as part of message discovery: instead of just doing ecdh between a recipient and an account added via
pxe.registerSender(), we can now store a tagging shared secret in pxe directly. Tags are then derived from these in the same way as ecdh-based tags, but these have the interesting property of not requiring knowledge of the sender's address. Combined with the upcoming non-interactive handshake registry, these are a means through which we can have non-interactive unconstrained onchain delivery.I renamed the
AddressStoretoTaggingSecretSourcesStore, since it is what it now is. The diff is a bit busy because of said rename, which ends up showing up in lots of files.There are not many interesting design decisions here. Notably pxe gets new methods for adding these secrets (which this PR doesn't yet wire anywhere), and we break backwards db compatibility due to the store renaming (but we don't care about that right now).