fix(ci): name the merge-train branch in Slack notifications - #24102
Merged
Conversation
AztecBot
added
ci-draft
alexghr
approved these changes
Jun 15, 2026
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
AztecBot
pushed a commit
that referenced
this pull request
Jun 16, 2026
## What The merge-train Slack notifications said `There was a failure in the merge-train` with no indication of *which* train. Now that several teams own multiple merge-trains that report to the same channel (e.g. `#team-alpha` receives both `merge-train/spartan` and `merge-train/spartan-v5`, `#team-fairies` gets `merge-train/fairies` and `merge-train/fairies-v5`), the messages were ambiguous. This includes the merge-train branch name (`$REF_NAME`) in all three notification messages in `ci3/merge_train_failure_slack_notify`: - **Failure:** `There was a failure in merge-train/spartan: http://ci.aztec-labs.com/...` - **Dequeued:** `PR was removed from the merge-train/spartan merge queue: ...` - **Merged:** `PR merged into merge-train/spartan: ...` The claudebox kickoff prompts already named `$REF_NAME`; only the human-facing Slack text was missing it. ## Why Requested in #team-alpha: notifications should specify which merge-train they refer to since there are now multiple merge-trains per team. --- *Created by [claudebox](https://claudebox.work/v2/sessions/95d94fda4cc1e492) · group: `slackbot`*
Collaborator
Author
|
✅ Successfully backported to backport-to-v5-next-staging #24118. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The merge-train Slack notifications said
There was a failure in the merge-trainwith no indication of which train. Now that several teams own multiple merge-trains that report to the same channel (e.g.#team-alphareceives bothmerge-train/spartanandmerge-train/spartan-v5,#team-fairiesgetsmerge-train/fairiesandmerge-train/fairies-v5), the messages were ambiguous.This includes the merge-train branch name (
$REF_NAME) in all three notification messages inci3/merge_train_failure_slack_notify:There was a failure in merge-train/spartan: http://ci.aztec-labs.com/...PR was removed from the merge-train/spartan merge queue: ...PR merged into merge-train/spartan: ...The claudebox kickoff prompts already named
$REF_NAME; only the human-facing Slack text was missing it.Why
Requested in #team-alpha: notifications should specify which merge-train they refer to since there are now multiple merge-trains per team.
Created by claudebox · group:
slackbot