refactor(aztec-nr): address constrained-delivery review comments - #24217
Merged
vezenovm merged 2 commits intoJun 22, 2026
Merged
Conversation
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
nchamo
marked this pull request as ready for review
June 20, 2026 20:56
nchamo
commented
Jun 20, 2026
|
|
||
| **Onchain delivery with guaranteed correct content.** | ||
|
|
||
| **WARNING**: This mode is [currently NOT fully constrained](https://github.com/AztecProtocol/aztec-packages/issues/14565). The log's tag is unconstrained, meaning a malicious sender could prevent the recipient from finding the message. |
Contributor
Author
There was a problem hiding this comment.
Undid the changes to this doc, so we can do them all together in #24040. It's very hard to build good docs in small steps
nchamo
commented
Jun 20, 2026
| #### Registering known senders | ||
|
|
||
| To discover address-secret notes from a particular sender, the recipient's PXE must know the sender's address in advance so it can compute the shared tagging secret. Register senders using the wallet API: | ||
| To discover notes from a particular sender, the recipient's PXE must know the sender's address in advance so it can compute the shared tagging secret. Register senders using the wallet API: |
Contributor
Author
There was a problem hiding this comment.
Undid the changes to this doc, so we can do them all together in #24040. It's very hard to build good docs in small steps
vezenovm
approved these changes
Jun 22, 2026
| } | ||
|
|
||
| #[test(should_fail_with = "reading an unknown nullifier")] | ||
| unconstrained fn fails_at_index_above_zero_without_prior_nullifier() { |
Contributor
There was a problem hiding this comment.
I agree with keeping the tests you left here (specifically this one which uses emit_constrained_log_without_nullifier) while the others are redundant with the new unit tests and the e2e as you mentioned in #23866 (comment).
vezenovm
merged commit Jun 22, 2026
7d4e98e
into
mv/f-669-constrained-delivery-helpers
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the review comments on #23866 (constrained message delivery). Branched off and based on that PR so these follow-up changes can be reviewed in isolation.
index > 0nullifier comment, switched secret resolution tomap/unwrap_or_else, and renamed "chain" -> "sequence" across code/tests to avoid colliding with the existing "chain" (blockchain) meaning.get_handshakesselector in the registry selector-match test, renamed the test helper toauthorizing, and dropped redundant TXE tests now covered by the e2e and unit suites (plus thedelivery_unconstrained_handshakecompile-failure pin).get_app_siloed_secretcaller-arg authorization check (avoids conflicting with feat(aztec-nr)!: add msg_sender to the utility context #24062), moved the registry-read helpers below the class, and reworked the cross-contract authorization test intoit.eachwith sharedbeforeEach/afterEach.pied!file that had been accidentally committed.The docs changes from the review are deferred to #24040, which owns the tagging-secret-source framing.