Skip to content

docs: require self-contained code comments - #24239

Merged
PhilWindle merged 1 commit into
merge-train/spartan-v5from
spl/claude-md-self-contained-comments
Jun 24, 2026
Merged

docs: require self-contained code comments#24239
PhilWindle merged 1 commit into
merge-train/spartan-v5from
spl/claude-md-self-contained-comments

Conversation

@spalladino

Copy link
Copy Markdown
Contributor

Adds a rule to the <writing_comments> section of the root CLAUDE.md: code comments must be understandable from the repo alone.

  • The repo is public but Linear issues are private, so comments must never cite them (e.g. // see A-1234).
  • Comments must not reference an implementation plan that lives outside the repo (e.g. // this fixes item 4, // tackles section C) — describe the actual constraint or behavior instead.

Placed in the root CLAUDE.md (not yarn-project/) since it applies to comments in any language across all components, alongside the existing rule against referencing PR/issue numbers.

@AztecBot

Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/87762c733694a221�87762c733694a2218;;�): yarn-project/kv-store/scripts/run_test.sh src/bench/sqlite-opfs-encrypted/map_bench.test.ts (2s) (code: 0)
\033FLAKED\033 (8;;http://ci.aztec-labs.com/b6a00b715f76e4ce�b6a00b715f76e4ce8;;�): yarn-project/kv-store/scripts/run_test.sh src/sqlite-opfs/internal/ordered-binary-browser.test.ts (2s) (code: 0)

@PhilWindle
PhilWindle merged commit a36600a into merge-train/spartan-v5 Jun 24, 2026
12 checks passed
@PhilWindle
PhilWindle deleted the spl/claude-md-self-contained-comments branch June 24, 2026 08:34
rangozd pushed a commit to rangozd/aztec-packages that referenced this pull request Aug 5, 2026
BEGIN_COMMIT_OVERRIDE
docs: add network-deployed-version skill (AztecProtocol#24238)
docs: require self-contained code comments (AztecProtocol#24239)
fix(archiver): validate checkpoint attestations from calldata before
fetching blobs (A-1252) (AztecProtocol#24247)
fix(sequencer): prune in failed-sync fallback so the chain can recover
(AztecProtocol#24253)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants