test(ci): give ASAN recursion-constraint test a 20m timeout - #24318
Closed
AztecBot wants to merge 2 commits into
Closed
test(ci): give ASAN recursion-constraint test a 20m timeout#24318AztecBot wants to merge 2 commits into
AztecBot wants to merge 2 commits into
Conversation
The build-asan-fast dsl_tests HonkRecursionConstraintTestWithoutPredicate/2.Tampering proves and verifies a full UltraHonk circuit. In isolation it runs ~3min, but its cost has grown with the verifier circuit and under the parallel full-test grind it now exceeds the 600s default timeout and is killed (code 124), dequeuing merge-train/spartan-v5 on every merge-queue attempt. Give it the same 20m budget as the other heavy recursion test.
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
merge-train/spartan-v5(PR #24272) keeps getting dequeuedThe train PR's merge-queue CI (
merge-queue-heavy, 10 grind runs) fails because a single ASAN unit test times out, not because of anything in the train's commits.The failing test, on every grind run:
code: 124is atimeoutkill, not an assertion failure. The dashboard history for this test onv5-nextshows it creeping up over a few days —~270s(06-24) →~400s(06-25) →>600s(06-26), and now all 10 grind runs hit the 600s default and are killed, dequeuing the train on eachAuto-merge/dequeuecycle.Root cause
This ASAN test proves and verifies a full UltraHonk circuit. Its cost has grown with the verifier circuit on the v5 line. In
barretenberg/cpp/bootstrap.sh,test_cmds_asanemits every ASAN test withCPUS=4:MEM=8g, so they inherit the 600s default timeout (ci3/source_test_params:TIMEOUT=${TIMEOUT:-600s}). The full suite runs through non-strictparallelize(CPU-based concurrency + GNU-parallel--memsuspendbackpressure), so under the parallel grind the test slows well past 600s and is killed.Fix
Give just this heavy ASAN recursion test a 20m timeout — the same budget already used for the other heavy recursion proving test (
bbapi_tests ChonkPinnedIvcInputsTest.AllPinnedFlows,TIMEOUT=20m). One-line behavioral change: the emitted command becomes…:CPUS=4:MEM=8g:TIMEOUT=20m ….Local verification
build-asan-fastdsl_testsand reproduced the originalgrumpkin g1 data not foundonly because the warm CRS was the pre-v2 format; afterbarretenberg/scripts/download_bb_crs.sh(fetchesgrumpkin_g1_v2.flat.dat), the test runs for real.[ OK ] HonkRecursionConstraintTestWithoutPredicate/2.Tampering (178752 ms)— passes in ~3min in isolation (peak ~10.9 GB). So this is a wall-clock-budget problem under grind contention, not a logic failure or hang; a longer timeout is the correct, minimal fix.source_test_paramsparses the multi-segment prefix andexec_testappliestimeout -v 20m.Full
./bootstrap.sh ci(merge-queue-heavy, EC2-orchestrated) can't run on this host, soci-fullis set here to exercise the ASAN path through PR CI.This is shared CI infra; landing it via the spartan-v5 train carries it into
v5-next, where the regression is observed.Created by claudebox · group:
slackbot