test: avoid redundant checker for failed ACIR tampering circuits - #24319
Closed
AztecBot wants to merge 2 commits into
Closed
test: avoid redundant checker for failed ACIR tampering circuits#24319AztecBot wants to merge 2 commits into
AztecBot wants to merge 2 commits into
Conversation
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge-train/spartan-v5train PR was dequeued from the merge queue.ci/x2-fullfailed on merge-group commit25a6fd11d37c06ff43967740fd5784c254ca598a.http://ci.aztec-labs.com/5e3aa1251cb22703:dsl_tests --gtest_filter=HonkRecursionConstraintTestWithoutPredicate/2.Tamperinghit the 600s timeout after the circuit had already reported invalid witnesses.create_circuithas already marked the builder failed, instead of running the expensiveCircuitChecker::check(builder)path again.barretenberg/docs/bootstrap.sh test:examples/recursive.test.tsexceeded its 300s Jest timeout after 313s on CI.Verification
git diff --check origin/merge-train/spartan-v5...HEADcmake --build --preset asan-fast --target dsl_testsNATIVE_PRESET=asan-fast CRS_PATH=/home/aztec-dev/.bb-crs ASAN_SYMBOLIZER_PATH=/usr/bin/llvm-symbolizer-20 barretenberg/cpp/scripts/run_test.sh dsl_tests HonkRecursionConstraintTestWithoutPredicate/2.Tamperingpassed in 100.7s.http://ci.aztec-labs.com/46d99818c657c21d.CI=1 barretenberg/docs/bootstrap.sh testpassed locally: 2 suites, 9 tests,examples/recursive.test.tsin 28.149s../bootstrap.sh ciis not a valid command on this branch; it exits withUnknown command: ci../bootstrap.sh ci-full-no-test-cachewas attempted locally. It started the full graph, but this session cannot complete it becausenoir/bootstrap.shfails before repo code builds while fetching Rust tooling (just@1.42.4) fromhttps://index.crates.io/config.jsonafter three attempts. The failure is a local external tooling/network prerequisite, not this patch.Related train PR: #24272
Created by claudebox · group:
slackbot