Skip to content

test: avoid redundant checker for failed ACIR tampering circuits - #24319

Closed
AztecBot wants to merge 2 commits into
merge-train/spartan-v5from
cb/fix-spartan-v5-honk-recursion-timeout
Closed

test: avoid redundant checker for failed ACIR tampering circuits#24319
AztecBot wants to merge 2 commits into
merge-train/spartan-v5from
cb/fix-spartan-v5-honk-recursion-timeout

Conversation

@AztecBot

@AztecBot AztecBot commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Investigated why the merge-train/spartan-v5 train PR was dequeued from the merge queue.
  • The latest removal was at 2026-06-26T05:37:18Z after ci/x2-full failed on merge-group commit 25a6fd11d37c06ff43967740fd5784c254ca598a.
  • The failing log was http://ci.aztec-labs.com/5e3aa1251cb22703: dsl_tests --gtest_filter=HonkRecursionConstraintTestWithoutPredicate/2.Tampering hit the 600s timeout after the circuit had already reported invalid witnesses.
  • Fixes the generic non-predicate ACIR tampering helper to return immediately when create_circuit has already marked the builder failed, instead of running the expensive CircuitChecker::check(builder) path again.
  • The first PR CI rerun confirmed that ASAN leaf now passes, then exposed a separate docs timeout in barretenberg/docs/bootstrap.sh test: examples/recursive.test.ts exceeded its 300s Jest timeout after 313s on CI.
  • Raises only that recursive docs proof timeout to 450s so the slow CI path can complete without changing the test behavior.

Verification

  • git diff --check origin/merge-train/spartan-v5...HEAD
  • cmake --build --preset asan-fast --target dsl_tests
  • NATIVE_PRESET=asan-fast CRS_PATH=/home/aztec-dev/.bb-crs ASAN_SYMBOLIZER_PATH=/usr/bin/llvm-symbolizer-20 barretenberg/cpp/scripts/run_test.sh dsl_tests HonkRecursionConstraintTestWithoutPredicate/2.Tampering passed in 100.7s.
  • CI ASAN leaf for the first fix passed: http://ci.aztec-labs.com/46d99818c657c21d.
  • CI=1 barretenberg/docs/bootstrap.sh test passed locally: 2 suites, 9 tests, examples/recursive.test.ts in 28.149s.
  • ./bootstrap.sh ci is not a valid command on this branch; it exits with Unknown command: ci.
  • ./bootstrap.sh ci-full-no-test-cache was attempted locally. It started the full graph, but this session cannot complete it because noir/bootstrap.sh fails before repo code builds while fetching Rust tooling (just@1.42.4) from https://index.crates.io/config.json after three attempts. The failure is a local external tooling/network prerequisite, not this patch.

Related train PR: #24272


Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-full-no-test-cache ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jun 26, 2026
@AztecBot

AztecBot commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed.

@AztecBot AztecBot closed this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-full-no-test-cache ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant