Skip to content

test(e2e): bound fee settings L1 base fee spike - #24355

Merged
spalladino merged 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-fee-settings
Jun 29, 2026
Merged

test(e2e): bound fee settings L1 base fee spike#24355
spalladino merged 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-fee-settings

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Summary

  • Change the fee-settings e2e helper to derive its target L1 base fee from the requested L2 fee rise instead of a fixed 0.1 gwei floor.
  • Keep the induced L2 min-fee spike meaningful while staying within the default padding cap asserted by the test.

Investigation

CI failed in single-node/fees/fee_settings › setting max fee per gas › handles min fee spikes with default padding at fee_settings.test.ts:225.

The failing log shows the fast automined L1 setup left anvil's current base fee at 7,192,495, but the helper raised the next block to the fixed 100,000,000 floor. That pushed L2 min fees from 110,501,300,000 to 1,031,260,100,000, while the default-padded max fee was only 663,007,800,000, so the test's padding assertion failed.

Testing

  • git diff --check
  • ./bootstrap.sh ci fails immediately on this branch with Unknown command: ci.
  • ./bootstrap.sh ci-full-no-test-cache was attempted because that is the CI-log bootstrap mode, but this local container fails before the e2e target: spartan requires sudo to install kubectl, and noir cannot fetch just@=1.42.4 from crates.io due a tunnel/DNS error.
  • Focused e2e command LOG_LEVEL=verbose yarn-project/end-to-end/scripts/run_test.sh simple src/single-node/fees/fee_settings.test.ts cannot start locally because yarn-project/node_modules/.bin/jest is missing.

Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jun 29, 2026
@AztecBot

Copy link
Copy Markdown
Collaborator Author

Flakey Tests

🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/3689fcc5d3d911aa�3689fcc5d3d911aa8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/single-node/proving/optimistic.parallel.test.ts "proves multiple epochs via checkpoint-driven flow" (514s) (code: 0) group:e2e-p2p-epoch-flakes
\033FLAKED\033 (8;;http://ci.aztec-labs.com/e8d20c393fb1cd2f�e8d20c393fb1cd2f8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/single-node/proving/multi_proof.test.ts (139s) (code: 0) group:e2e-p2p-epoch-flakes

@spalladino
spalladino marked this pull request as ready for review June 29, 2026 15:21
@spalladino
spalladino enabled auto-merge (squash) June 29, 2026 15:21
@spalladino
spalladino merged commit 8e39520 into merge-train/spartan-v5 Jun 29, 2026
67 of 71 checks passed
@spalladino
spalladino deleted the cb/fix-spartan-v5-fee-settings branch June 29, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants