refactor(aztec-nr): unify existing-handshake lookup for tag secret sources - #24435
Merged
nchamo merged 2 commits intoJul 1, 2026
Merged
Conversation
…urces default_tag_secret_source and TagDerivation::into_tag_secret_source's non-interactive-handshake branch both looked up an existing registered handshake and fell back differently when none existed. Extract the shared lookup into existing_handshake_secrets_or_else, parameterized by the fallback.
vezenovm
commented
Jul 1, 2026
nchamo
marked this pull request as ready for review
July 1, 2026 16:13
nchamo
merged commit Jul 1, 2026
61ab9c6
into
nchamo/handshake-tag-derivation
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default_tag_secret_source(the wallet-resolved default) andTagDerivation::into_tag_secret_source's non-interactive-handshake branch both looked up an existing registered handshake for(sender, recipient)and mapped it toTagSecretSource::existing_handshake(secrets), only differing in what ran when none existed.existing_handshake_secrets_or_else, parameterized by the fallback closure, intag_derivation.nr.Test plan
nargo checkpasses for theaztecpackagenargo testfailures for this file's tests (missing TXE oracle resolver) are unrelated to this change by reproducing them on the unmodified base branch