chore(prover-client): demote empty addTxs log from warn to verbose - #24593
Merged
spalladino merged 1 commit intoJul 7, 2026
Merged
Conversation
spalladino
approved these changes
Jul 7, 2026
spalladino
marked this pull request as ready for review
July 7, 2026 20:08
spalladino
enabled auto-merge (squash)
July 7, 2026 20:08
rangozd
pushed a commit
to rangozd/aztec-packages
that referenced
this pull request
Aug 5, 2026
Clean forward-port of AztecProtocol#24596 (merge-train spartan-v5, merge d2f4c4d, parents 42eea48..1737dfb) onto cb/private-port-next-7. Source base 42eea48 is AztecProtocol#24576's merge (block 4), so it stacks directly on block 4. Zero conflicts; tree touches exactly the 5 source-diff files: one code change (prover-client checkpoint-sub-tree-orchestrator empty-addTxs log demoted warn -> verbose, AztecProtocol#24593) + 4 docs (new yarn-project/THREAT_MODEL.md and p2p/reqresp/slasher READMEs, AztecProtocol#24465). No noir/circuit/pinned surfaces. Bundles sub-PRs AztecProtocol#24593 AztecProtocol#24465. Tracker: AztecProtocol/aztec-packages-private#588
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckpointSubTreeOrchestrator.addTxslogsProvided no txs to addTxs.at warn level, but this path is expected control flow, not an anomaly:checkpoint-prover.tscallsthis.subTree.addTxs(processed)unconditionally for every block in the checkpoint, so every empty block hits this early return (the empty block is then finalized viasetBlockCompleted). On low-traffic networks this fires constantly — ~100 times in 4h on staging-internal — polluting warn-level log reviews with noise.Demote it to
verbose. No behavior change; no tests assert on this message.Replaces #24591 and #24592 (closed), per request to land this as a single PR via the spartan-v5 merge train.
Spotted during a staging-internal log review requested by @spalladino in Slack.
Created by claudebox · group:
slackbot