docs: revert threat model for node (#24465) - #24610
Merged
Merged
Conversation
AztecBot
added
ci-draft
spalladino
changed the title
Restores yarn-project/p2p/README.md, yarn-project/p2p/src/services/reqresp/README.md, and yarn-project/slasher/README.md to their post-#24465 state. Per feedback, the revert should only remove the threat model doc itself, not the incidental doc cleanups (stale BLOCK protocol references, missing DUPLICATE_ATTESTATION entry) bundled into the same squashed commit.
spalladino
approved these changes
Jul 8, 2026
spalladino
marked this pull request as ready for review
July 8, 2026 18:00
spalladino
enabled auto-merge (squash)
July 8, 2026 18:00
PhilWindle
pushed a commit
that referenced
this pull request
Jul 21, 2026
Removes `yarn-project/THREAT_MODEL.md`, added in [#24465](#24465). Per discussion in #team-alpha: detailed threat models and invariants may make it easier for attackers to find bugs, so the team wants this content pulled from the public repo for now. It will be re-added to LabsBox/ClaudeBox (private/internal) — see [claudebox#1357](AztecProtocol/claudebox#1357) — and can come back here once the team is finding fewer bugs. Only the threat model doc itself is removed here — the incidental doc cleanups bundled into the same squashed commit (stale BLOCK protocol references in `yarn-project/p2p/README.md` and `yarn-project/p2p/src/services/reqresp/README.md`, and the missing `DUPLICATE_ATTESTATION` entry in `yarn-project/slasher/README.md`) are kept as-is. (cherry picked from commit 4d02692)
PhilWindle
pushed a commit
that referenced
this pull request
Jul 21, 2026
Removes `yarn-project/THREAT_MODEL.md`, added in [#24465](#24465). Per discussion in #team-alpha: detailed threat models and invariants may make it easier for attackers to find bugs, so the team wants this content pulled from the public repo for now. It will be re-added to LabsBox/ClaudeBox (private/internal) — see [claudebox#1357](AztecProtocol/claudebox#1357) — and can come back here once the team is finding fewer bugs. Only the threat model doc itself is removed here — the incidental doc cleanups bundled into the same squashed commit (stale BLOCK protocol references in `yarn-project/p2p/README.md` and `yarn-project/p2p/src/services/reqresp/README.md`, and the missing `DUPLICATE_ATTESTATION` entry in `yarn-project/slasher/README.md`) are kept as-is. (cherry picked from commit 4d02692)
2 tasks
rangozd
pushed a commit
to rangozd/aztec-packages
that referenced
this pull request
Aug 5, 2026
…ol#24610) Removes `yarn-project/THREAT_MODEL.md`, added in [AztecProtocol#24465](AztecProtocol#24465). Per discussion in #team-alpha: detailed threat models and invariants may make it easier for attackers to find bugs, so the team wants this content pulled from the public repo for now. It will be re-added to LabsBox/ClaudeBox (private/internal) — see [claudebox#1357](AztecProtocol/claudebox#1357) — and can come back here once the team is finding fewer bugs. Only the threat model doc itself is removed here — the incidental doc cleanups bundled into the same squashed commit (stale BLOCK protocol references in `yarn-project/p2p/README.md` and `yarn-project/p2p/src/services/reqresp/README.md`, and the missing `DUPLICATE_ATTESTATION` entry in `yarn-project/slasher/README.md`) are kept as-is. (cherry picked from commit 4d02692)
rangozd
pushed a commit
to rangozd/aztec-packages
that referenced
this pull request
Aug 5, 2026
…Protocol#24934) Forward-ports the small **cli / bot / docs** commits of the v5-next → next backlog, plus an owner checklist for the spartan-config and standard-contract-repin commits (both need an explicit v6 decision — see below). ## Applied (clean cherry-picks, chronological) - perf(bot): parallelize independent bot factory setup steps (AztecProtocol#24581) - docs: revert threat model for node (AztecProtocol#24465) (AztecProtocol#24610) - feat(cli): support funding accounts in validator-keys new/set-funding-account (AztecProtocol#24476) ##⚠️ Needs owner conflict-resolution (conflict against reshaped `next`; not included here) Cherry-pick onto this branch and resolve: - [x] `git cherry-pick -x 38202d9` — chore(spartan): restore 7 day mainnet slash grace period (AztecProtocol#24804) - [x] `git cherry-pick -x c3a2a85` — chore: re-pin handshake registry with owner-bound nullifiers (AztecProtocol#24893) Part of the manual v5-next → next backlog sweep. Draft until conflicts are resolved and CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
yarn-project/THREAT_MODEL.md, added in #24465.