Skip to content

fix(aztec-nr): tolerate malformed partial-note completion logs #24668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nventuro merged 4 commits into from
Jul 15, 2026
Merged

fix(aztec-nr): tolerate malformed partial-note completion logs #24668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9db5d3
fix(aztec-nr): tolerate malformed partial-note completion logs
nchamo Jul 13, 2026
625321c
test: update token contract expand snapshot
nchamo Jul 13, 2026
e76b80e
docs(aztec-nr): reword partial-note completion-log comments
nchamo Jul 14, 2026
4b410e0
fix(aztec-nr): guard partial-note append overflow and empty logs
nchamo Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions noir-projects/aztec-nr/aztec/src/messages/processing/log_retrieval_response.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
use crate::messages::logs::note::MAX_NOTE_PACKED_LEN;
use crate::protocol::{constants::{MAX_NOTE_HASHES_PER_TX, PRIVATE_LOG_CIPHERTEXT_LEN}, traits::Deserialize};
use crate::protocol::{
constants::{MAX_NOTE_HASHES_PER_TX, PRIVATE_LOG_CIPHERTEXT_LEN},
traits::{Deserialize, Serialize},
};

pub global MAX_PUBLIC_LOG_LEN_FOR_NOTE_COMPLETION: u32 = MAX_NOTE_PACKED_LEN;

Expand All @@ -11,7 +14,7 @@ pub(crate) global MAX_LOG_CONTENT_LEN: u32 = std::cmp::max(
/// A response to a `LogRetrievalRequest`, containing the payload of a log (i.e. the content minus the tag, called
/// plaintext for public logs and ciphertext for private), plus contextual information about the transaction in which
/// the log was emitted. This is the data required in order to discover notes that are being delivered in a log.
#[derive(Deserialize, Eq)]
#[derive(Deserialize, Eq, Serialize)]
pub struct LogRetrievalResponse {
pub log_payload: BoundedVec<Field, MAX_LOG_CONTENT_LEN>,
pub tx_hash: Field,
Expand Down
7 changes: 7 additions & 0 deletions noir-projects/aztec-nr/aztec/src/messages/processing/mod.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,13 @@ pub unconstrained fn enqueue_note_for_validation(
))
}

/// The note validation requests enqueued so far in the current context via [`enqueue_note_for_validation`], before
/// [`validate_and_store_enqueued_notes_and_events`] drains them. Exists so tests can inspect the pending queue;
/// production code should not read requests back once enqueued.
pub(crate) unconstrained fn get_enqueued_note_validation_requests() -> EphemeralArray<NoteValidationRequest> {
EphemeralArray::at(NOTE_VALIDATION_REQUESTS_ARRAY_BASE_SLOT)
}

/// Enqueues an event for validation and storage by PXE.
///
/// This is the primary way for custom message handlers (registered via
Expand Down
Loading
Loading