chore: barebones constants-codegen project - #24687
Merged
Merged
Conversation
mverzilli
marked this pull request as ready for review
July 15, 2026 09:14
replace them with a new remake-constants.sh that invokes the new cli
mverzilli
force-pushed
the
martin/constants-codegen
branch
from
July 15, 2026 09:28
2c9a635 to
68602b1
Compare
charlielye
approved these changes
Jul 16, 2026
charlielye
reviewed
Jul 16, 2026
| "README.md" | ||
| ], | ||
| "scripts": { | ||
| "build": "tsc -p tsconfig.json", |
Contributor
There was a problem hiding this comment.
We might be able to fully ditch tsc here. e.g. in ipc-codegen.
Recent node that we have requirement on has experimental TS type stripping built in.
Contributor
Author
There was a problem hiding this comment.
I tried this but stumbled upon this, which means apparently we can't fully ditch it if we want to eventually publish it as a package: https://nodejs.org/api/typescript.html#type-stripping-in-dependencies
(I guess this hasn't been an issue with ipc-codegen so far as it is not yet packaged?)
Anyway, it does mean we can simplify runs in our own CI: e392bce#diff-1b3ca05af0b7eb9d08af88e7497463e1d6a91e6576752a7148a9b649e4607cfcL38-L48
mverzilli
added
ci-release-pr
AztecBot
removed
the
ci-release-pr
This was referenced Jul 21, 2026
rangozd
pushed a commit
to rangozd/aztec-packages
that referenced
this pull request
Aug 5, 2026
BEGIN_COMMIT_OVERRIDE chore: remove obsolete no_predicates wrappers (AztecProtocol#7729) (AztecProtocol#24050) chore: barebones constants-codegen project (AztecProtocol#24687) chore: constants codegen release (AztecProtocol#24728) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new
constants-codegenpackage at a newprotocoltld.remake-constantstask to keep blast ratio low for nowyarn-projects/constantswill be further simplified in subsequent PRsCloses F-814, F-815, F-819