chore(ci): drop redundant nightly-release-tag-v5-next workflow#24751
Open
AztecBot wants to merge 1 commit into
Open
chore(ci): drop redundant nightly-release-tag-v5-next workflow#24751AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Thunkar
approved these changes
Jul 16, 2026
Thunkar
marked this pull request as ready for review
July 16, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
.github/workflows/nightly-release-tag-v5-next.yml, keeping the pre-existingnightly-release-tag.ymlas the single nightly tagger.Why
The two scheduled workflows had started pushing the identical nightly tag on the public repo, so the second run of the night failed on a duplicate tag:
nightly-release-tag.yml(4 AM UTC) — matrix tagger: public →v5-next, private →next+v5-next.nightly-release-tag-v5-next.yml(5 AM UTC, added in 7ac407c) — always tagsv5-nexton the public repo only.Both check out
v5-nextand buildv${manifest.version}-nightly.$(date +%Y%m%d), so on the public repo they produce the exact same tag. On the night of 2026-07-15 the 4 AM run (#497) createdv5.0.0-nightly.20260715, and the 5 AM run (first-ever scheduled run) failed:7ac407c added the
-v5-next.ymltagger on the assumption thatnightly-release-tag.ymltaggednexton public. Two days later #23984 repointed that workflow's public matrix leg from[next, v5-next]to[v5-next]("public should not produce anextnightly tag; v6/next nightly lives on private"), which made the two workflows' public output identical.Why drop this one (the smaller of the two)
nightly-release-tag.ymlis a strict superset:nightly-release-tag.yml(kept)nightly-release-tag-v5-next.yml(removed)v5-nextv5-next(duplicate)next+v5-nextifgate is public-only)workflow_dispatchRemoving the smaller file eliminates the duplicate-tag failure while preserving every current behaviour: the surviving workflow already tags public
v5-next, privatenext(v6) +v5-next(v5), and keeps aworkflow_dispatchbutton for ad-hoc runs. Deleting the other file instead would have silently dropped all private-repo nightly tagging.Testing
Workflow-file-only change; no code paths affected. Verified the surviving
nightly-release-tag.ymlat thenexttip still carries the full repo-dependent matrix (private → [next, v5-next],public → [v5-next]) andworkflow_dispatch.Full diagnosis: https://gist.github.com/AztecBot/9aa164d7949a3cf68c7aebaaa1333649
Created by claudebox · group:
slackbot