fix(bb): port secp256r1 unique-lookup-index soundness fix to public v5-next - #24842
Merged
Merged
Conversation
Replace the secp256r1-specific unique/positive table_index test with one that sweeps every basic table reachable through any MultiTable. The LogDeriv relation identifies a table solely by table_index, so this guards against any generator (not just secp256r1 fixed-base) storing a window or bit-slice position in place of the builder-assigned index.
Generated by ci-refresh-chonk. Only the pinned Chonk input hash is committed here; the immediate follow-up CI run is skipped intentionally. --ci-skip
fix(bb): assign unique secp256r1 lookup table indices
iakovenkos
approved these changes
Jul 21, 2026
aminsammara
added this pull request to the merge queue
Jul 21, 2026
ludamad
approved these changes
Jul 21, 2026
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
AztecBot
added a commit
that referenced
this pull request
Jul 24, 2026
…4936) Forward-ports the **barretenberg secp256r1 unique-lookup-index soundness fix** to `next` — missed by the initial area-bucketed sweep because its PR-numbered wrapper (#24842) is a merge commit and its content commits carry no `(#N)` suffix (they arrived via merge PR #647), so both the `--no-merges` and `(#N)` filters dropped them. ## Applied (clean cherry-picks, chronological) - `c6ab912228` fix(bb): assign unique secp256r1 lookup table indices - `3a53c977e4` test(bb): generalize lookup table-index invariant across all tables - `f013e4497f` comment cleanup Corresponds to v5-next #24842. Part of the manual v5-next → next backlog sweep. --------- Co-authored-by: AztecBot <tech@aztec-labs.com> Co-authored-by: ledwards2225 <l.edwards.d@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings public
v5-nextup toprivate/v5-next(eb52040bd1), porting the barretenberg secp256r1 fixed-base lookup-table soundness fix.Net change (6 files, all under
barretenberg/cpp/)table_indexto each secp256r1 fixed-base lookup table, and add finalize-time guards that reject duplicate or zero table indices, with a new circuit-checker test (Secp256r1FixedBaseTablesGetUniquePositiveIndices,FinalizationRejectsDuplicateTableIndices,FinalizationRejectsZeroTableIndex).Notes for reviewers
chore: sync public-v5-next with upstream v5-nextmerge nodes that sit between the two tips; those carry no net file change. The only net delta is the fix + the chonk hash bump.mergeonly). The public→private sync will reconcilev5-nextafterward, so private stays a fast-forward of public.