fix: slice undersized crs in browser (backport #24894) - #25124
Merged
Conversation
(cherry picked from commit cbd096d)
IlyasRidhuan
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #24894 to
v5-next, requested in Slack (release5.1.1/5.2.0scoping — the fix is blocking browser work).Clean cherry-pick of
cbd096d(-x), no conflicts. One file, +5/-1: when the browser cache holds a larger CRS, slice it to exactlynumPoints * 64bytes so the WASM compressed/uncompressed auto-detection does not throwinvalid points_buf size. Onv5-nextthe file lives atbarretenberg/ts/src/crs/browser/cached_net_crs.ts(it moved tobarretenberg/ts/bb.js/src/...onnext). The resulting blob is byte-identical to the one merged onnext(2de1743).Why the automatic backport never ran
#24894did carrybackport-to-v5-next, andbackport.ymlfired on bothlabeled(09:19) andclosed(11:44) on 2026-07-22, but each run skipped theBackport/port PRjob because the label gate reported failure:dfb6942 (2026-07-16) set the gate to
agilepathway/label-checkerwithprefix_mode: trueandany_of: backport-to-,port-to-next. That action only supports a single prefix. The merge-event run log shows it verbatim:So
steps.check.outputs.label_checkwasfailure, the job'sstateoutput wasfailure, and thebackportjob'sif: ... needs.label_checker.outputs.state == 'success'was never satisfied →Backport/port PR=skipped.The failure was silent:
allow_failure: truekept theCheck labelsjob green (so the whole run concludedsuccess), and both the "❌ Failed to cherry-pick" PR comment and the#backportsSlack alert live inside the skippedbackportjob, so neither fired. Nothing anywhere said the backport had been dropped.The gate was rewritten as a direct
jqprefix check in 010569d (feat(ci): auto forward-port v5 merge-train PRs to next #24848). That fix reachednextin merge commit cc4f066, whose first parent isb5cd35c— this PR's own merge commit. In other words the fix is literally the next commit onnextafter#24894, so#24894was the last PR to merge under the broken gate. (Commit author/committer timestamps are misleading here: they record merge-queue entry, not landing order — ancestry does.)Affected window
PRs labeled
backport-to-*/port-to-nextthat merged betweendfb6942(2026-07-16) andcc4f066(2026-07-22) had their backports silently dropped. Checking thebackport-to-v5-nextPRs that merged in that window againstv5-next:v5-next?fix(ci): move nightly bench inclusion sweep to 06:00 UTC71f8e3d, arrived by another route)The automation itself is fixed going forward —
backport-to-v5-next-stagingis currently drained and in sync withv5-next.Created by claudebox · group:
slackbot· Slack thread