Repository navigation
refactor: rename GasPrice to FeesPerGas in l1 tx utils - #25152
Merged
Merged
Conversation
`GasPrice` holds `{ maxFeePerGas, maxPriorityFeePerGas, maxFeePerBlobGas? }` — the EIP-1559 fee caps a tx
carries, not a gas price. The name collides with the things that really are gas prices: viem's
`PublicClient.getGasPrice()` (a legacy scalar bigint), `receipt.effectiveGasPrice`, and `stats.gasPrice`.
`l1TxUtils.getGasPrice()` and `client.getGasPrice()` read identically at a call site and return different shapes.
Renames the type and the identifiers that name the cap set, so "gas price" now means only a scalar wei-per-gas
price. Keys already written to disk keep their names, with a comment saying why.
benesjan
force-pushed
the
jb/rename-gas-price-to-fee-caps
branch
from
August 10, 2026 11:27
59c1fde to
47f68fb
Compare
benesjan
marked this pull request as ready for review
August 10, 2026 12:38
benesjan
changed the title
GasPrice to FeeCaps in l1 tx utils
Contributor
|
Code for the rename looks ok, but I'm not sold on the new name. I've seen I don't intend to die in this hill, so if you feel very strongly about the new name I'm ok approving, but I also don't see the need for the rename, given |
Follows viem's naming for the same EIP-1559 values.
benesjan
changed the title
GasPrice to FeeCaps in l1 tx utilsGasPrice to FeesPerGas in l1 tx utils
Contributor
Author
|
Renamed to |
spalladino
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original name was very misleading as gas price has a real meaning - that's the gas price paid for when the L1 tx is mined. For this reason I am renaming
GasPriceasFeesPerGas, following viem's naming for the same EIP-1559 values.Old naming is handled by the stores so this should be fine to merge.