fix: TxEffect deserializability (forward port of #25109) - #25295
Merged
Merged
Conversation
mverzilli
requested review from
nchamo and
nventuro
and removed request for
LeilaWang
August 24, 2026 14:45
nchamo
approved these changes
Aug 24, 2026
mverzilli
added this pull request to the merge queue
Aug 24, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 24, 2026
mverzilli
added this pull request to the merge queue
Aug 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 25, 2026
nchamo
enabled auto-merge
August 25, 2026 20:02
nchamo
added this pull request to the merge queue
Aug 25, 2026
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
mverzilli
added a commit
to aztec-labs-eng/aztec-node
that referenced
this pull request
Aug 26, 2026
…ec-packages#25109) (#86) * fix: port TxEffect deserializability test coverage (AztecProtocol/aztec-packages#25109) Ports the labs half of the original PR: the TxEffectOracleTest contract gains a batch get_tx_effects_hashes utility and a TXE test checking batch results match the singular oracle. The Deserialize derive on TxEffect itself lives in protocol_types, consumed from aztec-packages at a pinned nightly tag; this compiles once the pin advances past a tag containing that derive. * chore: bump toolchain pins to 6.0.0-nightly.20260826 Advances the aztec-packages pin past AztecProtocol/aztec-packages#25295 so protocol_types carries the Deserialize derive on TxEffect that the tx_effect_oracle_test_contract batch oracle test requires. Noir pin is unchanged: the noir submodule is identical between the two nightlies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-ports #25109 to
next.The batch oracle's Noir wrapper
get_tx_effectsreturns anEphemeralArray<Option<TxEffect>>, but reading an element out of anEphemeralArrayrequires the element type to implementDeserialize, whichTxEffectdoes not — so a contract can obtain the array and ask for its length, but any attempt to read an element fails to compile.#25109 fixed this on the v5 line (shipped in v5.2.0), but the fnd/labs split (#25007) copied
tx_effect.nrto its new location onnextbefore the fix landed there, sonextnever received it. This applies the same change; the resulting file is byte-identical to the one shipped in v5.2.0.The contract-side test coverage from the original PR is ported to the labs repo (aztec-labs-eng/aztec-node), where it is blocked on a nightly tag containing this change.