Skip to content

feat: Goblin documentation #4679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ledwards2225 merged 7 commits into from
Feb 29, 2024
Merged

feat: Goblin documentation #4679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
85f86f9
add worktodo
TohruKohrita Feb 20, 2024
0e69238
Added underlying assumption on aggregate op queue
TohruKohrita Feb 20, 2024
55e82b8
add underlying assumption on the size of aggregate op queue
TohruKohrita Feb 20, 2024
5980880
Merge branch 'master' into tk/document_goblin
TohruKohrita Feb 23, 2024
eb0a921
remove WORKTODO
TohruKohrita Feb 23, 2024
a0b1dcf
run formatter
ledwards2225 Feb 29, 2024
47c30a8
Merge branch 'master' into tk/document_goblin
ledwards2225 Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions barretenberg/cpp/src/barretenberg/ultra_honk/merge_prover.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ MergeProver_<Flavor>::MergeProver_(const std::shared_ptr<ECCOpQueue>& op_queue)
* @details Let T_i^(j) be the jth column of the aggregate op queue after incorporating the contribution from the
* present circuit. T_{i-1}^(j) corresponds to the aggregate op queue at the previous stage and $t_i^(j)$ represents
* the contribution from the present circuit only. For each j, we have the relationship T_i = T_{i-1} + right_shift(t_i,
* M_{i-1}), where the shift magnitude M_{i-1} is the length of T_{i-1}. This protocol demonstrates that the aggregate
* op queue has been constructed correctly via a simple Schwartz-Zippel check. Evaluations are proven via batched KZG.
* M_{i-1}), where the shift magnitude M_{i-1} is the honest length of T_{i-1}. This protocol demonstrates, assuming the
* length of T_{i-1} is at most M_{i-1}, that the aggregate op queue has been constructed correctly via a simple
* Schwartz-Zippel check. Evaluations are proven via batched KZG.
*
* TODO(#746): Prove connection between t_i^{shift}, committed to herein, and t_i, used in the main protocol. See issue
* for details (https://github.com/AztecProtocol/barretenberg/issues/746).
Expand Down
5 changes: 3 additions & 2 deletions barretenberg/cpp/src/barretenberg/ultra_honk/merge_verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ MergeVerifier_<Flavor>::MergeVerifier_()
* @details Let T_i^(j) be the jth column of the aggregate op queue after incorporating the contribution from the
* present circuit. T_{i-1}^(j) corresponds to the aggregate op queue at the previous stage and $t_i^(j)$ represents
* the contribution from the present circuit only. For each j, we have the relationship T_i = T_{i-1} + right_shift(t_i,
* M_{i-1}), where the shift magnitude M_{i-1} is the length of T_{i-1}. This protocol verfies that the aggregate op
* queue has been constructed correctly via a simple Schwartz-Zippel check. Evaluations are checked via batched KZG.
* M_{i-1}), where the shift magnitude M_{i-1} is the honest length of T_{i-1}. This protocol verfies, assuming the
* length of T_{i-1} is at most M_{i-1}, that the aggregate op queue has been constructed correctly via a simple
* Schwartz-Zippel check. Evaluations are checked via batched KZG.
*
* @tparam Flavor
* @return HonkProof&
Expand Down