Skip to content

fix: add TODO with issue for num_gates bug #4847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rumata888 merged 1 commit into from
Feb 29, 2024
Merged

fix: add TODO with issue for num_gates bug #4847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions barretenberg/cpp/src/barretenberg/proof_system/circuit_builder/ultra_circuit_builder.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,9 @@ class UltraCircuitBuilder_ : public CircuitBuilderBase<typename Arithmetization_
* 5) Number of non-native field multiplication gates.
*
* @return size_t
* TODO(https://github.com/AztecProtocol/barretenberg/issues/875): This method may return an incorrect value before
* the circuit is finalized due to a failure to account for "de-duplication" when computing how many
* non-native-field gates will be present.
*/
size_t get_num_gates() const override
{
Expand Down