Repository navigation
Conversation
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
8bfa2ac to
bbf04ca
Compare
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Values are compared against data from master at commit L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contracts are deployed in the tx.
Transaction processing duration by data writes.
|
73e7a3f to
f020ff2
Compare
97d4f3c to
8dc5687
Compare
Docs PreviewHey there! 👋 You can check your preview at https://65e1b37751e5edbe34300e21--aztec-docs-dev.netlify.app |
f020ff2 to
485cbc3
Compare
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
|
How about placing errors in the Alternatively, I'd place the error types next to the interfaces that throw them. So the ArchiverErrors should live next to where the Archiver interface lives. |
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. What's wrong with native code?Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs. Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
The foundation also throw quite a few errors, so was to allow it to be used in there without going full circular. |
|
Closing this as I never returned to it. If we figure it is interesting we can reopen it. |
3 participants
Initial playing around with consolidating errors in one location and then using them throughout.
Essentially, I was dying inside when I see the duplicated strings around the codebase. They make it cumbersome to alter the error structures and error prone when writing failing tests.
Instead I propose that we are writing them in one place like:
This we can then reuse which should make it less error prone and easier to figure out where the errors are used. Also makes it easy to figure out what error messages are never explicitly tested so we can add those easily.
Issues encountered:
Errors are inconsistently passed along, which makes interaction and testing a little strange.
For example, the following code will do as expected, and the test will pass
However, if using a private function instead, it will fail, with an error around the message and cause received being different to expected.
But if only looking at the message, it passes just fine.