chore: remove knowledge of aztec function types from compiler - #4975
Merged
spalladino merged 3 commits intoMar 6, 2024
Merged
Conversation
Member
Author
|
I'm assuming that all the contract artifacts get fed through the AVM transpiler so perhaps this could parse the custom attributes and set the function type, etc (although this could just be done on the fly). |
TomAFrench
commented
Mar 6, 2024
TomAFrench
commented
Mar 6, 2024
spalladino
reviewed
Mar 6, 2024
spalladino
left a comment
spalladino
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks @TomAFrench! I just left a question to double check, but if it's fine, I'll merge with my PR. Next step (which I can tackle) would be to tweak yarn-project/types/src/abi/contract_artifact.ts#loadContractArtifact to understand the attributes for populating the fields we expect in ts-land.
| match ty { | ||
| "Private" => func.def.return_distinctness = Distinctness::Distinct, | ||
| "Public" => func.def.is_open = true, | ||
| "Public" => func.def.is_unconstrained = true, |
Contributor
There was a problem hiding this comment.
For compilation purposes (ie emitting ACIR or Brillig or AVM bytecode), is it equivalent to flag the function as unconstrained instead of open? @TomAFrench @Maddiaa0 @sirasistant
Member
Author
There was a problem hiding this comment.
"open" implies AVM, no? We should compile to brillig in this case so we should tell the Noir compiler that it should compile the function as if it were unconstrained.
Member
Author
There was a problem hiding this comment.
We don't output AVM bytecode so we can only output ACIR or brillig.
spalladino
pushed a commit
that referenced
this pull request
Mar 6, 2024
This PR removes the concept of a function being internal or "open" from the Noir compiler as these are now concepts which are aztec specific. We instead attach all of a contract functions custom attributes to it in the build artifact so aztec can parse these to determine whether a function is open or secret, etc. @spalladino This follows on from #4967 but I've made this as a separate PR into yours as I don't want to hijack it.
spalladino
pushed a commit
that referenced
this pull request
Mar 7, 2024
This PR removes the concept of a function being internal or "open" from the Noir compiler as these are now concepts which are aztec specific. We instead attach all of a contract functions custom attributes to it in the build artifact so aztec can parse these to determine whether a function is open or secret, etc. @spalladino This follows on from #4967 but I've made this as a separate PR into yours as I don't want to hijack it.
spalladino
pushed a commit
that referenced
this pull request
Mar 11, 2024
This PR removes the concept of a function being internal or "open" from the Noir compiler as these are now concepts which are aztec specific. We instead attach all of a contract functions custom attributes to it in the build artifact so aztec can parse these to determine whether a function is open or secret, etc. @spalladino This follows on from #4967 but I've made this as a separate PR into yours as I don't want to hijack it.
spalladino
pushed a commit
that referenced
this pull request
Mar 11, 2024
This PR removes the concept of a function being internal or "open" from the Noir compiler as these are now concepts which are aztec specific. We instead attach all of a contract functions custom attributes to it in the build artifact so aztec can parse these to determine whether a function is open or secret, etc. @spalladino This follows on from #4967 but I've made this as a separate PR into yours as I don't want to hijack it.
spalladino
pushed a commit
that referenced
this pull request
Mar 11, 2024
This PR removes the concept of a function being internal or "open" from the Noir compiler as these are now concepts which are aztec specific. We instead attach all of a contract functions custom attributes to it in the build artifact so aztec can parse these to determine whether a function is open or secret, etc. @spalladino This follows on from #4967 but I've made this as a separate PR into yours as I don't want to hijack it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the concept of a function being internal or "open" from the Noir compiler as these are now concepts which are aztec specific. We instead attach all of a contract functions custom attributes to it in the build artifact so aztec can parse these to determine whether a function is open or secret, etc.
@spalladino This follows on from #4967 but I've made this as a separate PR into yours as I don't want to hijack it.