Skip to content

Modify comments in the security proofs - #5588

Merged
IlyasRidhuan merged 1 commit into
ir/avm_cmpfrom
jm/avm_cmp_modified_comments
Apr 5, 2024
Merged

IlyasRidhuan merged 1 commit into
ir/avm_cmpfrom
jm/avm_cmp_modified_comments

Conversation

@jeanmon

@jeanmon jeanmon commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@jeanmon
jeanmon marked this pull request as ready for review April 5, 2024 14:51
@IlyasRidhuan
IlyasRidhuan merged this pull request into ir/avm_cmp Apr 5, 2024
@IlyasRidhuan
IlyasRidhuan deleted the jm/avm_cmp_modified_comments branch April 5, 2024 15:05
@github-actions

github-actions Bot commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

Changes to circuit sizes

Generated at commit: 5153bb9b26855c9cd5aa06e353c661ca515acbe8, compared to commit: cc56e7a19652375a68eb1001180df2ee691366d2

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init +2 ❌ +0.00% +898 ❌ +0.26%
public_kernel_app_logic +7 ❌ +0.01% +593 ❌ +0.18%
public_kernel_setup +4 ❌ +0.01% +311 ❌ +0.12%
public_kernel_teardown +4 ❌ +0.01% +311 ❌ +0.12%
private_kernel_inner +1 ❌ +0.00% +312 ❌ +0.06%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init 48,536 (+2) +0.00% 349,381 (+898) +0.26%
public_kernel_app_logic 66,990 (+7) +0.01% 333,205 (+593) +0.18%
public_kernel_setup 54,817 (+4) +0.01% 262,159 (+311) +0.12%
public_kernel_teardown 54,928 (+4) +0.01% 262,270 (+311) +0.12%
private_kernel_inner 95,799 (+1) +0.00% 520,238 (+312) +0.06%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants