Add constant historic tree roots to public kernel inputs - #577
Merged
Conversation
PhilWindle
approved these changes
May 16, 2023
spalladino
force-pushed
the
palla/public-kernel-inputs-add-constant-data
branch
from
May 16, 2023 12:44
b293811 to
2d3ac73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds constant data to the "public kernel with no previous kernel" circuit, so it can be forwarded to the outputs. Instead of adding the full
CombinedConstantDatastruct, we're adding just the historic tree roots, since the tx context can be obtained from the signed tx request.Fixes #482