Skip to content

feat: Sync from noir - #5935

Merged
TomAFrench merged 8 commits into
masterfrom
sync-noir
Apr 23, 2024
Merged

feat: Sync from noir#5935
TomAFrench merged 8 commits into
masterfrom
sync-noir

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: remove pub wildcard import of ast into noirc_frontend root (noir-lang/noir#4862)
chore: remove SecondaryAttribute::Event (noir-lang/noir#4868)
chore: more explicit self parameter in Into trait (noir-lang/noir#4867)
chore: remove initialisation of logger in acvm_js tests (noir-lang/noir#4850)
chore: bump MSRV to 1.74.1 (noir-lang/noir#4873)
chore: update NoirJS tutorial (noir-lang/noir#4861)
chore(docs): remove link to play.noir-lang.org (noir-lang/noir#4872)
chore: update noir README (noir-lang/noir#4856)
feat(experimental): Add comptime keyword (noir-lang/noir#4840)
feat: add min and max functions to the stdlib (noir-lang/noir#4839)
feat: Allow numeric generics to non inlined ACIR functions (noir-lang/noir#4834)
chore!: Add as_array and remove _slice variants of hash functions (noir-lang/noir#4675)
feat!: reserve keyword super (noir-lang/noir#4836)
feat: simplify BoundedVec::eq (noir-lang/noir#4838)
feat: Add comptime Interpreter (noir-lang/noir#4821)
feat: Sync from aztec-packages (noir-lang/noir#4833)
feat: implement Eq trait on BoundedVec (noir-lang/noir#4830)
chore: add benchmarks for serializing a dummy program (noir-lang/noir#4813)
END_COMMIT_OVERRIDE

AztecBot and others added 5 commits April 22, 2024 18:41
…tend` root (noir-lang/noir#4862)

chore: remove `SecondaryAttribute::Event` (noir-lang/noir#4868)
chore: more explicit `self` parameter in `Into` trait (noir-lang/noir#4867)
chore: remove initialisation of logger in `acvm_js` tests (noir-lang/noir#4850)
chore: bump MSRV to `1.74.1` (noir-lang/noir#4873)
chore: update NoirJS tutorial (noir-lang/noir#4861)
chore(docs): remove link to play.noir-lang.org (noir-lang/noir#4872)
chore: update noir README (noir-lang/noir#4856)
feat(experimental): Add `comptime` keyword (noir-lang/noir#4840)
feat: add `min` and `max` functions to the stdlib (noir-lang/noir#4839)
feat: Allow numeric generics to non inlined ACIR functions (noir-lang/noir#4834)
chore!: Add `as_array` and remove `_slice` variants of hash functions (noir-lang/noir#4675)
feat!: reserve keyword `super` (noir-lang/noir#4836)
feat: simplify `BoundedVec::eq` (noir-lang/noir#4838)
feat: Add comptime Interpreter (noir-lang/noir#4821)
feat: Sync from aztec-packages (noir-lang/noir#4833)
feat: implement `Eq` trait on `BoundedVec` (noir-lang/noir#4830)
chore: add benchmarks for serializing a dummy program (noir-lang/noir#4813)
Comment thread noir-projects/noir-contracts/contracts/card_game_contract/src/cards.nr Outdated
Comment thread noir-projects/noir-contracts/contracts/ecdsa_account_contract/src/main.nr Outdated
@AztecBot

ghost commented Apr 22, 2024

Copy link
Copy Markdown
Collaborator Author

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 772 772 772
l1_rollup_calldata_gas 6,844 6,820 6,832
l1_rollup_execution_gas 587,325 587,301 587,313
l2_block_processing_time_in_ms 1,497 (+2%) 5,319 (-4%) 10,160 (-3%)
note_successful_decrypting_time_in_ms 197 (+22%) 385 (-2%) 659 (-2%)
note_trial_decrypting_time_in_ms 85.9 (+60%) 81.4 (-8%) 65.6 (-19%)
l2_block_building_time_in_ms 18,695 (-1%) 72,844 (-1%) 145,123 (-1%)
l2_block_rollup_simulation_time_in_ms 18,482 72,086 (-1%) 143,650 (-1%)
l2_block_public_tx_process_time_in_ms 8,428 (-1%) 33,055 65,881 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 16,248 (-2%) 30,485 (-2%)
note_history_successful_decrypting_time_in_ms 900 (+3%) 1,759 (+2%)
note_history_trial_decrypting_time_in_ms 122 (+25%) 78.7 (-38%)
node_database_size_in_bytes 19,107,920 36,102,224 (+1%)
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 154 (-3%) 47,763 31,978
private-kernel-inner 175 (-2%) 80,794 31,978
private-kernel-ordering 136 (-1%) 57,732 50,043
base-parity 74.1 128 265
root-parity 124 (-2%) 1,244 265
base-rollup 12,196 (-2%) 110,926 957
root-rollup 50.0 (+1%) 4,551 821
public-kernel-app-logic 1,646 (-1%) 62,017 52,067
public-kernel-tail 4,233 (-1%) 168,566 7,491
merge-rollup 3,134 (-1%) 2,760 957
public-kernel-teardown 120 (+3%) 62,017 52,067
public-kernel-setup 118 (+1%) 62,017 52,067

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.0 (+1%) 17.7 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.640 0.546 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 51.6 (+1%) 80.3 257 (-1%) 505 (+1%) 981 1,933 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.529 (+1%) 0.495 0.469 (-1%) 0.471 (+1%) 0.465 0.463 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 60.5 119 375 743 (+1%) 1,466 2,902 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.535 0.537 0.511 0.511 (+1%) 0.508 0.506 (-1%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 67.8 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.591

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 51,411 543,524

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 897 1,145 1,345

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,260 (+2%) 857 (-1%) 3,509 (+1%)
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 829 (-1%) 753 (-1%) 1,340 (-1%) 898 2,071 1,082

Tom French and others added 2 commits April 22, 2024 21:12
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
Comment thread noir-projects/noir-contracts/contracts/ecdsa_account_contract/src/main.nr Outdated
@TomAFrench
TomAFrench enabled auto-merge (squash) April 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants