feat!: specify databus arrays for BB - #6239
Merged
Merged
Conversation
ghost
changed the title
vezenovm
reviewed
May 7, 2024
| block_id: BlockId, | ||
| init: Vec<Witness>, | ||
| /// 0 for regular memory, 1 for call-data and 2 for return-data | ||
| databus: u8, |
Contributor
There was a problem hiding this comment.
I feel an enum would be clearer here and it also aligns with how we have been distinguishing opcodes already
ghost
deleted the
gd/databus_opcode
branch
May 8, 2024 12:36
ghost
mentioned this pull request
This was referenced May 17, 2024
ghost
mentioned this pull request
ghost
mentioned this pull request
ghost
mentioned this pull request
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a field to the MemoryInit opcode to specify the memory blocks used for the databus.
It is related to issue noir-lang/noir#4974
This is a breaking change because it modifies ACIR format.