Skip to content

chore: use Noir implementation of pedersen in public (uses MSM instead of pedersen BBs) #8798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbanks12 merged 3 commits into from
Sep 27, 2024
Merged

chore: use Noir implementation of pedersen in public (uses MSM instead of pedersen BBs) #8798

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c74274
chore: use Noir implementation of pedersen that uses MSM instead of p…
Sep 25, 2024
d8a50c1
Merge branch 'master' into 09-25-chore_use_Noir_implementation_of_ped…
fcarreiro Sep 27, 2024
4adc013
Merge branch 'master' into 09-25-chore_use_Noir_implementation_of_ped…
dbanks12 Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions noir/noir-repo/noir_stdlib/src/hash/mod.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,11 @@ pub fn pedersen_commitment<let N: u32>(input: [Field; N]) -> EmbeddedCurvePoint
}

pub fn pedersen_hash_with_separator<let N: u32>(input: [Field; N], separator: u32) -> Field {
__pedersen_hash_with_separator(input, separator)
pedersen_hash_with_separator_noir(input, separator)
}

pub fn pedersen_commitment_with_separator<let N: u32>(input: [Field; N], separator: u32) -> EmbeddedCurvePoint {
let value = __pedersen_commitment_with_separator(input, separator);
if (value[0] == 0) & (value[1] == 0) {
EmbeddedCurvePoint { x: 0, y: 0, is_infinite: true }
} else {
EmbeddedCurvePoint { x: value[0], y: value[1], is_infinite: false }
}
pedersen_commitment_with_separator_noir(input, separator)
}

#[no_predicates]
Expand Down Expand Up @@ -78,7 +73,7 @@ fn pedersen_hash_with_separator_noir<let N: u32>(input: [Field; N], separator: u
pub fn pedersen_hash<let N: u32>(input: [Field; N]) -> Field
// docs:end:pedersen_hash
{
__pedersen_hash_with_separator(input, 0)
pedersen_hash_with_separator_noir(input, 0)
}

#[foreign(pedersen_hash)]
Expand Down