Skip to content

chore: default logging level to debug if debug set #9173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 6 commits into from
Oct 11, 2024
Merged

chore: default logging level to debug if debug set #9173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2417869
fix: default logging level to debug if debug set
ludamad Oct 11, 2024
bb0cd1a
Merge branch 'master' into ad/default-log-level-if-debug
ludamad Oct 11, 2024
ac94d25
Merge branch 'master' into ad/default-log-level-if-debug
ludamad Oct 11, 2024
8b78126
Merge branch 'master' into ad/default-log-level-if-debug
ludamad Oct 11, 2024
98ba4d4
formatting
ludamad Oct 11, 2024
8cf9fcb
Merge remote-tracking branch 'origin/ad/default-log-level-if-debug' i…
ludamad Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions yarn-project/aztec/src/logging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { onLog, setLevel } from '@aztec/foundation/log';
import { currentLevel, onLog, setLevel } from '@aztec/foundation/log';

import * as path from 'path';
import * as process from 'process';
Expand Down Expand Up @@ -55,7 +55,7 @@ function createWinstonJsonStdoutLogger(
return info;
});
return winston.createLogger({
level: process.env.LOG_LEVEL ?? 'info',
level: currentLevel,
transports: [
new winston.transports.Console({
format: format.combine(format.timestamp(), ignoreAztecPattern(), format.json()),
Expand Down
11 changes: 8 additions & 3 deletions yarn-project/foundation/src/log/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,20 @@ import { inspect } from 'util';
import { type LogData, type LogFn } from './log_fn.js';

const LogLevels = ['silent', 'error', 'warn', 'info', 'verbose', 'debug'] as const;
const DefaultLogLevel = process.env.NODE_ENV === 'test' ? ('silent' as const) : ('info' as const);

/**
* A valid log severity level.
*/
export type LogLevel = (typeof LogLevels)[number];

const envLogLevel = process.env.LOG_LEVEL?.toLowerCase() as LogLevel;
export let currentLevel = LogLevels.includes(envLogLevel) ? envLogLevel : DefaultLogLevel;
function getLogLevel() {
const envLogLevel = process.env.LOG_LEVEL?.toLowerCase() as LogLevel;
const defaultNonTestLogLevel = process.env.DEBUG === undefined ? ('info' as const) : ('debug' as const);
const defaultLogLevel = process.env.NODE_ENV === 'test' ? ('silent' as const) : defaultNonTestLogLevel;
return LogLevels.includes(envLogLevel) ? envLogLevel : defaultLogLevel;
}

export let currentLevel = getLogLevel();

const namespaces = process.env.DEBUG ?? 'aztec:*';
debug.enable(namespaces);
Expand Down