Conversation
6 tasks
Contributor
Author
|
Ported to AztecProtocol/aztec-packages#298. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The constants
EMPTY_COMMITMENTS_SUBTREE_ROOT, EMPTY_CONTRACTS_SUBTREE_ROOTwere being computed at compile-time (which itself is mysterious, it shouldn't have been computed at compile-time). As a result, the pedersen lookup tables were being filled at compile time, setting the variableinitedtotrue. But when you start the actual execution, the variableinited = truebut the tables are now empty. This PR fixes this only at a high-level: avoid using those two variables.(Edit: This was a problem only with ultra-plonk because we use lookup tables.)
Longer term, we would like to instantiate the tables only once so we should store them on disc and load them as necessary. Issue AztecProtocol/barretenberg#362 explains this in a bit more detail.
Checklist:
/specshave been updated.@briefdescribing the intended functionality.