Skip to content

Fix Rollup Tests (for Local testing) - #250

Closed
suyash67 wants to merge 1 commit into
masterfrom
sb/local-base-rollup-fix
Closed

suyash67 wants to merge 1 commit into
masterfrom
sb/local-base-rollup-fix

Conversation

@suyash67

@suyash67 suyash67 commented Apr 17, 2023 •

Copy link
Copy Markdown
Contributor

Description

The constants EMPTY_COMMITMENTS_SUBTREE_ROOT, EMPTY_CONTRACTS_SUBTREE_ROOT were being computed at compile-time (which itself is mysterious, it shouldn't have been computed at compile-time). As a result, the pedersen lookup tables were being filled at compile time, setting the variable inited to true. But when you start the actual execution, the variable inited = true but the tables are now empty. This PR fixes this only at a high-level: avoid using those two variables.

(Edit: This was a problem only with ultra-plonk because we use lookup tables.)

Longer term, we would like to instantiate the tables only once so we should store them on disc and load them as necessary. Issue AztecProtocol/barretenberg#362 explains this in a bit more detail.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

Note
If you are updating the submodule, please make sure you do it in its own special PR and avoid making changes to the submodule as a part of other PRs.
To update a submodule, you can run the following commands:

$ git submodule update --recursive

Alternatively, you can select a particular commit in barretenberg/aztec3 that you wish to point to:

$ cd barretenberg
$ git pull origin aztec3        # This will point to the latest commit in `barretenberg/aztec3`
$ git checkout <commit_hash>    # Use this if you wish to point to a particular commit.
$ cd ..
$ git add . && git commit -m <commit_msg>
$ git push

@dbanks12 dbanks12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suyash67

Copy link
Copy Markdown
Contributor Author

Ported to AztecProtocol/aztec-packages#298.

@suyash67 suyash67 closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants