You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should clarify and simplify the handling of state in Protogalaxy. Examples:
auto is overused and makes it hard to navigate.
the name "accumulator" is used for objects that are not being treated as an accumulator (the idea is that these objects have the same type as an accumulator, but IMO the naming here is confusing and should be improved)
the is_accumulator flag in the ProverInstance is a bit of a misnomer--I believe this sometimes is more properly an "is_first_round".
There is a bad pattern in that part of the code where objects are default constructed when probably they should be copy constructed.
Activity
refactor: clean up compute_next_accumulator (#5516)
refactor: clean up compute_next_accumulator (#5516)
iakovenkos commentedon Nov 6, 2025
clarified!