Skip to content

Upgrade Azure.Security.KeyVault.Secrets to use KeyVaultSecretIdentifier.Parse() for KeyVault reference URI validation #222

Closed
#351
Closed
Upgrade Azure.Security.KeyVault.Secrets to use KeyVaultSecretIdentifier.Parse() for KeyVault reference URI validation#222
#351
Assignees
avanigupta
Labels
enhancementNew feature or requestgood first issueGood for newcomers

Description

@avanigupta
Avani Gupta (avanigupta)
opened on Dec 10, 2020

I see we should start using KeyVaultSecretIdentifier.Parse. Since this next release will be adding a new API, and bumping a minor version. It will probably be a good candidate release for us to bump to Azure.Security.KeyVault.Secrets 4.1.0 to use this API.

We have no need to document the URI format. We shouldn't be aware of it.

Originally posted by Jimmy Campbell (@jimmyca15) in #210 (comment)

Activity

  1. avanigupta commented on Dec 10, 2020

    @avanigupta
    Avani Gupta (avanigupta)
    on Dec 10, 2020
    MemberAuthor

    KeyVaultSecretIdentifier.Parse is only available in preview release right now. We can update this as soon as 4.2.0 package is released for Azure.Security.KeyVault.Secrets.

  2. Avani Gupta (avanigupta)
    self-assigned this
    on Dec 10, 2020
  3. Zhenlan Wang (zhenlan)
    added
    enhancementNew feature or request
    on Mar 21, 2021
  4. Avani Gupta (avanigupta)
    added
    good first issueGood for newcomers
    on Aug 19, 2021

  5. avanigupta commented on Aug 19, 2021

    @avanigupta
    Avani Gupta (avanigupta)
    on Aug 19, 2021
    MemberAuthor

    Azure.Security.KeyVault.Secrets v4.2.0 was released but it doesn't have the original KeyVaultSecretIdentifier.TryParse API. Tracking this feature request for Key Vault SDK team to add it again.

  6. avanigupta commented on Aug 29, 2022

    @avanigupta
    Avani Gupta (avanigupta)
    on Aug 29, 2022
    MemberAuthor

    Azure.Security.KeyVault.Secrets 4.3.0 version contains the required API.

  7. Avani Gupta (avanigupta)
    linked a pull request that will close this issueupdate keyvault secrets package version to 4.3.0, use TryCreate for validation #351on Aug 31, 2022
  8. Amer Jusupovic (amerjusupovic)
    closed this as completedin #351on Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestgood first issueGood for newcomers

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions