Skip to content

Should keep the original precedence after dedup selectors with same filters #490

Closed

Description

@Eskibear

After the dedup of selectors with exact same key filter and label filter, the precedence of selectors should not change.

Consider case:

        options.Select("app.*", "dev");
        options.Select("app.*", "prod");
        options.Select("app.*", "dev");

Without dedup, "dev" wins. Dedup logic below will remove last occurrence, "prod" will win eventually. The dedup causes the change of precedence.

if (!_kvSelectors.Any(s => s.KeyFilter.Equals(keyFilter) && s.LabelFilter.Equals(labelFilter)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions