Skip to content

Pull main into preview for preview release - #602

Closed
Ross Grambo (rossgrambo) wants to merge 7 commits into
previewfrom
main
Closed

Ross Grambo (rossgrambo) wants to merge 7 commits into
previewfrom
main

Conversation

@rossgrambo

Copy link
Copy Markdown
Contributor

No description provided.

* add secret client option

* update comment

* rename to configure

* use callback configuration pattern

* remove unused package
* increase default maxretries for key vault client to max value

* update minimum secret refresh interval to 1 minute, enforce for refresh all operations as well

* PR comments

* PR comments

* update max retries default for key vault

* update to use sourceid as key in cached secret dictionary

* move retries number to const int

* call invalidate cache with previous setting if current one is null

* add comment explaining number of key vault retries

* pull out utcnow as a variable in for loop in clearcache

@avanigupta Avani Gupta (avanigupta) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be merged with a merge commit (not squash)

@rossgrambo

Copy link
Copy Markdown
Contributor Author

This PR is superseded by #604 since there was a conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants