Skip to content

Add connector JSON, Forcepoint logo and sample data#471

Merged
preetikr merged 6 commits into
Azure:masterfrom
tom-meaney-forcepoint:forcepoint-ngfw-connector
Feb 11, 2020
Merged

Add connector JSON, Forcepoint logo and sample data#471
preetikr merged 6 commits into
Azure:masterfrom
tom-meaney-forcepoint:forcepoint-ngfw-connector

Conversation

@tom-meaney-forcepoint

@tom-meaney-forcepoint tom-meaney-forcepoint commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

Fixes #

Proposed Changes

  • Add Connector JSON file
  • Add Forcepoint SVG logo
  • Add Sample data

@msftclas

msftclas commented Feb 6, 2020

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@preetikr preetikr closed this Feb 8, 2020
@preetikr preetikr reopened this Feb 8, 2020
Comment thread DataConnectors/FORCEPOINT_NGFW.json Outdated
"id": "FORCEPOINT_NGFW",
"title": "Forcepoint NGFW",
"publisher": "Forcepoint",
"descriptionMarkdown": "The Forcepoint NGFW connector allows you to automatically export user-defined Forcepoint NGFW logs into Azure Sentinel in real-time. This enriches visibility into user activities recorded by NGFW, enables further correlation with data from Azure workloads and other feeds, and improves monitoring capability with Workbooks inside Azure Sentinel.​",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Expand out the abbreviation at least one time initially as "the Forcepoint NGFW (Next Generation Firewall) connector allows..."
  2. I see formatting issues when I load this connector at the end of the description 'Azure Sentinel.' Just delete some part of 'Sentinel.' and the retype it to remove the weird characters and import the file to validate using the import test tool/functionality.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for resolving #1 - #2 is not resolved

Comment thread DataConnectors/FORCEPOINT_NGFW.json Outdated
Comment thread DataConnectors/FORCEPOINT_NGFW.json Outdated
Comment thread DataConnectors/FORCEPOINT_NGFW.json Outdated
Comment thread DataConnectors/FORCEPOINT_NGFW.json Outdated

@preetikr preetikr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides fixing the weird char issue (added review comment), we need the redirection link for Forcepoint inserted as well before I can approve and merge the PR.

Comment thread DataConnectors/FORCEPOINT_NGFW.json Outdated

@preetikr preetikr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the last couple of issues and picking up for deployment

@preetikr preetikr merged commit 97b4292 into Azure:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants